Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramaterized skin "reFold" #40

Open
Shades84 opened this issue Mar 9, 2023 · 6 comments
Open

Paramaterized skin "reFold" #40

Shades84 opened this issue Mar 9, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Shades84
Copy link

Shades84 commented Mar 9, 2023

I recently remade this skin in such a way that doesn't require having PNGs for the buttons. You can set the text, icon, and colors all within the skin "ini" file. I'm calling it "reFold". Would it make sense to push that to this repo or to make a separate one?

@Ruben35
Copy link
Owner

Ruben35 commented Mar 9, 2023

I would like to see the new way of doing this icons to check if it is a better approach make a new repo in order to mantain the older buttons or just make a new branch for the "reFold" buttons and, at the moment the "reFold" buttons completely replace the older ones, we can switch as main the "reFold" branch.

I suggest you at this moment to fork this project and make a new empty branch in order to see how the reFold one looks and how they are configured.

@Ruben35 Ruben35 self-assigned this Mar 9, 2023
@Ruben35 Ruben35 added the enhancement New feature or request label Mar 9, 2023
@Shades84
Copy link
Author

Shades84 commented Mar 9, 2023

Alright, you can find it here https://github.com/Shades84/reFold-Rainmeter. Let me know if you have any questions!

@ItsIgnacioPortal
Copy link
Contributor

ItsIgnacioPortal commented Mar 9, 2023

I see that that template loads the text fine. But can it load an icon image? the templates you added to that repo don't have an icon.

If we implement this succesfully, it'll make it much faster to create new icons. This will also let us cut the ammount of images in half, since we'll only need the icon and not the text. Good addition if you can get it to work

@Shades84
Copy link
Author

Shades84 commented Mar 9, 2023

ahh, yeah probably should have uploaded that, my mistake. Users are going to be providing their own icons, so i didn't think to include the example one.

@ItsIgnacioPortal
Copy link
Contributor

ItsIgnacioPortal commented Mar 21, 2023

Looks good! Could you make a pull request into this repo? You'll have to make a new CONTRIBUTING.md, and add the template files with the example icon. Future reFold icons will be in @Resources/reFold. Check #42

@Ruben35 what do you think?

@Shades84
Copy link
Author

can do. How should I do the CONTRIBUTING.md file? A new separate file or make an addition to the existing one? I'm going to revert my changes in the readme. Also, if anyone has the icons already, in png or svg, that would be a big time saver for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants