Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing tap and doubletap on the same element not working on the latest version #35

Open
equilerex opened this issue Feb 16, 2015 · 5 comments
Milestone

Comments

@equilerex
Copy link

Using the latest version, tap and double tap can't be used at the same time on the same element,

the issue seems to be that the "type" passed into "function addRecognizer (manager, type)" is in one case an object {type:tap} instead of string "tap"

ive made an example here (see the console for errors and button actions):
http://codepen.io/anon/pen/ByYMqx

@mattmcdonald-uk
Copy link

You can work around this bug (one way: do a typeof check on type, if object use type.type), but doing so will cause several tap events to be fired for every doubletap.

To avoid that you would need to make use of requireFailure, but that is a current issue (#23).

Perhaps fixing this should be part of the work for #24?

@equilerex
Copy link
Author

yeah, i tried it with type.type but since the old version was working fine, i just continued using that one til it gets a fix... just wanted to point it out if it had not already been found ;)

@RyanMullins
Copy link
Owner

Check out the fix in #36, I think that will address your issue. I'm swamped with other stuff at the moment, so this won't be published in a release until at least the weekend (21 Feb 2015).

@RyanMullins RyanMullins added this to the 2.1.11 milestone Feb 19, 2015
@luohaoGit
Copy link

have your problem solved?

@kfei
Copy link

kfei commented Sep 16, 2015

@RyanMullins Any plan on publishing next release to include #36? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants