Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventGhosts not needed? #39

Open
johnpapa opened this issue Mar 23, 2015 · 2 comments
Open

preventGhosts not needed? #39

johnpapa opened this issue Mar 23, 2015 · 2 comments

Comments

@johnpapa
Copy link

I'm trying to verify that ng-click is indeed firing if I do not set prevetnGhosts. however my sample is not showing any ng-clicks being evented , so I checked out your demo (see link below) and it is also not showing anything for any ng-clicks. Does this mean preventGhosts is no longer needed? Or do I misunderstand the purpose?

http://ryanmullins.github.io/angular-hammer/examples/raw/tap

Also, the demo does not record anything at all when tapping or clicking on the 2nd and 4th options (recognizer with prevent ghosts and stop propogation)

@johnpapa johnpapa changed the title preventGhosts demo not working preventGhosts not needed? Mar 23, 2015
@kosich
Copy link

kosich commented Mar 31, 2015

I got "ghost clicks" on hm-tap directive handlers with chrome's device emulation of "Notebook with touch". So first touchstart and touchend fire (triggering hammer's tap event) and then mousedown->mouseup->click guys come up, also triggering hammer's tap.

Though currently I can only test it in chrome's emulation (got no real device available).

@RyanMullins
Copy link
Owner

Can you please verify this issue persists with the changes from #55 and update this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants