You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the Manager and Recogniser options are both attributes that accept JSON (L124), this causes issues when it is necessary to change things like the inputClass as that method requires a function and not a string.
Switching to model based options would be better. This could be done with isolate scope (I don't know if that would cause issues as I haven't tested) or by calling a model on the scope using a value passed into an attribute. For example, Line 124 could become:
managerOpts = scope[attrs.hmManagerOptions]
And instead of passing through JSON you instead pass through a model name:
hm-manager-options="options"
Then all options can be set in a model on the controller.
I'm happy to submit a pull request for this if you're happy with the change. Obviously this would be a breaking change but it would mean that you could change the inputClass, something we need to do in this project.
The text was updated successfully, but these errors were encountered:
Currently the Manager and Recogniser options are both attributes that accept JSON (L124), this causes issues when it is necessary to change things like the
inputClass
as that method requires a function and not a string.Switching to model based options would be better. This could be done with isolate scope (I don't know if that would cause issues as I haven't tested) or by calling a model on the scope using a value passed into an attribute. For example, Line 124 could become:
managerOpts = scope[attrs.hmManagerOptions]
And instead of passing through JSON you instead pass through a model name:
hm-manager-options="options"
Then all options can be set in a model on the controller.
I'm happy to submit a pull request for this if you're happy with the change. Obviously this would be a breaking change but it would mean that you could change the inputClass, something we need to do in this project.
The text was updated successfully, but these errors were encountered: