Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Possible bug in self.wait(). #3

Open
Blonck opened this issue Apr 26, 2022 · 1 comment · May be fixed by #8
Open

Possible bug in self.wait(). #3

Blonck opened this issue Apr 26, 2022 · 1 comment · May be fixed by #8

Comments

@Blonck
Copy link

Blonck commented Apr 26, 2022 •
edited
Loading

Hi,

The videos within the pptx files does not occur in the correct slides. I guess this is due to some changes in manim. self.wait() does not generate a partial movie (at least in the version I used v0.15.1).

That is the fix in my fork (Blonck@b87ea48). Should I make an PR?

PS: Thank you very much for this package; it is exactly what I searched for for a while.
@RythenGlyth
Copy link
Owner

For me it was working last time I checked. The problem with your solution is that you can't create a slide without an animation.
If you have another idea on how to fix this problem please tell me/create a PR

LXYan2333 added a commit to LXYan2333/manim-pptx that referenced this issue Oct 11, 2022
@LXYan2333
fix RythenGlyth#3
efce883 
fix RythenGlyth#3
code from Blonck@b87ea48
@LXYan2333 LXYan2333 linked a pull request Oct 11, 2022 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #3 LXYan2333/manim-pptx
2 participants
@Blonck @RythenGlyth