Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and proposal of new products #25

Closed
wants to merge 16 commits into from
Closed

Conversation

elpem
Copy link
Contributor

@elpem elpem commented Jul 27, 2021

I've been using this repo for a project for Wavestone (french company) and I've been able to find products that weren't present in this repo. Also, I updated some links and company names which were outdated or dead.
It's my first time contributing to an opensource project, so I hope I did everything well, and I stay aware if you need any modification on this work or any more information.

My work with Wavestone will be published soon. If you want, I can send it to you or drop it somewhere in the repo.

@S3cur1tyH4ggis
Copy link
Owner

Hey, thank you for the great pull request! Glad to hear you've found it useful. Let me take a look over the next week or so and we'll get it published :-)

Thanks, Rob

@S3cur1tyH4ggis
Copy link
Owner

Hi Léo

Sorry for taking so long to get round to looking at your commit. It is a busy period for me.

A query for you. You have added a number of entries to Network Anomaly Detection. I have been considering (#15 ) removing most of this category because of the big overlap with the Asset Discovery and Profiling category. I feel that most solutions sit more naturally there.

Any views on this?

Thanks
Rob

@S3cur1tyH4ggis
Copy link
Owner

Another query. In the IAM category you have added two "Fast Switching" solutions. I'd not heard of these but I see they could be useful for some usecases. My query is how they are ICS-specific? From a brief review of the web pages, they appear to be more corporate solutions.

@S3cur1tyH4ggis
Copy link
Owner

For now, I have cherry-picked most of your updates in commit 7f6c0b9, except to NAD.md and IAM.md pending my two comments above.

Thanks again for your large pull request :-)

@elpem
Copy link
Contributor Author

elpem commented Aug 20, 2021

Another query. In the IAM category you have added two "Fast Switching" solutions. I'd not heard of these but I see they could be useful for some usecases. My query is how they are ICS-specific? From a brief review of the web pages, they appear to be more corporate solutions.

Yes it's not ICS specific but I find it useful in shared endpoint management, which is pretty common in ICS. So I let you decide whether you keep it or not in the repo, as it is indeed not ics specific

@S3cur1tyH4ggis
Copy link
Owner

Thank you, I'll leave fast switching out of IAM for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants