Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision Code is inefficient, slow and buggy. #106

Closed
ILOVEPIE opened this issue Feb 7, 2024 · 1 comment
Closed

Collision Code is inefficient, slow and buggy. #106

ILOVEPIE opened this issue Feb 7, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
First Release

Comments

@ILOVEPIE
Copy link
Member

ILOVEPIE commented Feb 7, 2024 •
edited
Loading

Describe the bug
the functions at:
/src/renderer-main.js:1687
/src/renderer-main.js:1434
/src/renderer-main.js:1164
/src/renderer-main.js:1313
need to be reworked so they're more efficient and less buggy.

Additional context
The code as it is doesn't position text correctly on some of the test cases I have, we need to isolate why and optimize the collision code.
@ILOVEPIE ILOVEPIE added the bug Something isn't working label Feb 7, 2024
@ILOVEPIE ILOVEPIE added this to the First Release milestone Feb 7, 2024
@ILOVEPIE ILOVEPIE moved this to Backlog in SABRE.js Feb 19, 2024
@ILOVEPIE
Copy link
Member Author

ILOVEPIE commented Nov 7, 2024

this was fixed with #122

@ILOVEPIE ILOVEPIE closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in SABRE.js Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
SABRE.js
Status: Done
Milestone
First Release
Development

No branches or pull requests
1 participant
@ILOVEPIE