fixup! test(selenium): run tests across multiple {browser, js} combin…

…ations
SADiLaR · Nov 7, 2024 · 7a589a0 · 7a589a0
1 parent 06f7020
commit 7a589a0
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 7 deletions.
diff --git a/app/general/tests/files/test_js.html b/app/general/tests/files/test_js.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html lang="en">
+
+<body>
+    <script>
+        document.querySelector("body").innerHTML = "<p id='js-enabled'>Hello world!</p>";
+    </script>
+</body>
+</html>
diff --git a/app/general/tests/test_frontend.py b/app/general/tests/test_frontend.py
@@ -4,10 +4,7 @@
 from django.test import tag
 from selenium.common import TimeoutException
 from selenium.webdriver.chrome.webdriver import (
-    Options as ChromeOptions,
-)
-from selenium.webdriver.chrome.webdriver import (
-    WebDriver as ChromeWebDriver,
+    Options as ChromeOptions, WebDriver as ChromeWebDriver
 )
 from selenium.webdriver.common.by import By
 from selenium.webdriver.firefox.webdriver import (
@@ -27,22 +24,34 @@ class TestFrontend(StaticLiveServerTestCase):
     @classmethod
     def setUpClass(cls):
         browser = os.environ.get("BROWSER", "chrome").lower()
-        js_enabled = os.environ.get("JS_ENABLED", "js-enabled") == "js-enabled"
+        cls.js_enabled = os.environ.get("JS_ENABLED", "js-enabled") == "js-enabled"
 
         print(
-            f"Running Selenium tests on {browser}. JS is {'enabled' if js_enabled else 'disabled'}."
+            f"Running Selenium tests on {browser}. JS is {'enabled' if cls.js_enabled else 'disabled'}."
         )
 
         if browser == "chrome":
             opts = ChromeOptions()
-            opts.add_argument("--headless")
+            opts.add_argument("--headless=new")
             opts.add_argument("--no-sandbox")
             opts.add_argument("--disable-dev-shm-usage")
             opts.add_argument("--window-size=1920,1080")
+
+            if not cls.js_enabled:
+                # Taken from https://stackoverflow.com/a/73961818
+                prefs = dict()
+                prefs["webkit.webprefs.javascript_enabled"] = False
+                prefs["profile.content_settings.exceptions.javascript.*.setting"] = 2
+                prefs["profile.default_content_setting_values.javascript"] = 2
+                prefs["profile.managed_default_content_settings.javascript"] = 2
+                opts.add_experimental_option("prefs", prefs)
+                opts.add_argument('--disable-javascript')
+
             cls.driver = ChromeWebDriver(opts)
         elif browser == "firefox":
             options = FirefoxOptions()
             options.add_argument("-headless")
+            options.set_preference("javascript.enabled", cls.js_enabled)
             cls.driver = FirefoxWebDriver(options=options)
 
         cls.driver.implicitly_wait(WAIT_TIMEOUT)
@@ -54,6 +63,12 @@ def tearDownClass(cls):
         cls.driver.quit()
         super().tearDownClass()
 
+    # Checks that JS is properly disabled if passed through env var, else check if enabled
+    def test_js_enabled_or_disabled(self):
+        test_dir = os.getenv("TESTING_DIR", "/app/general/tests/files")
+        self.driver.get(f"file://{test_dir}/test_js.html")
+        self.assertEqual(len(self.driver.find_elements(By.ID, "js-enabled")), 1 if self.js_enabled else 0)
+
     def test_no_404s(self):
         # Sanity check in case we ever change the 404 title
         self.driver.get(f"{self.live_server_url}/blabla404")