Default Filters #16
Open
Default Filters #16
+999
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Carl Önnheim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
carlonnheim
commented
Mar 6, 2023
| @@ -119,7 +120,7 @@ | |||
| } | |||
| }, | |||
| "initialLoad": true, | |||
| "views": { | |||
| "XviewsX": { | |||
There was a problem hiding this comment.
This should not be here, but having both active at the same time crashes the app.
|
Hi @carlonnheim, Hope that is fine & BR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @schiwekM,
First of all, thanks for this great repository. By far the best source of reference for FE on oData v4!
I would suggest to add samples regarding Default Filters, documented here?
I have added one in this PR. Notably the Default Filters are not working in combination with views (I have disabled that in the PR, if you turn that back on, the app will not load).
I have raised that as a support incident too with number 183769 / 2023, in case you are engaged in that channel too.
Thanks in advance!
//Carl