Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSE with SAPMachine OpenJDK #929

Closed
blueicehaller opened this issue Aug 20, 2021 · 4 comments
Closed

KSE with SAPMachine OpenJDK #929

blueicehaller opened this issue Aug 20, 2021 · 4 comments
Labels
question rfe Request for Enhancement sapmachineonly Issues/changes affecting only SapMachine

Comments

@blueicehaller
Copy link

Hi,

can you please implement that the SapMachine installer sets the following registry values?

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft]

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft\Java Runtime Environment]
"CurrentVersion"="11.0"

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft\Java Runtime Environment\11.0]
"JavaHome"="C:\\Program Files\\SapMachine\\JDK\\11"
"MicroVersion"="0"

Further Information: kaikramer/keystore-explorer#292

Thank you in advance.

@nice2mitja nice2mitja added question rfe Request for Enhancement sapmachineonly Issues/changes affecting only SapMachine labels Aug 26, 2021
@nice2mitja
Copy link
Member

Hey there,

thanks for reaching out! I will check your request and get back soon with further information!

@MBaesken
Copy link
Member

Hi, are you aware of the registry entries we already have?
https://github.com/SAP/SapMachine-infrastructure/blob/master/wix-templates/SapMachine.jdk.wxs.template#L51
Reusing the proposed JavaSoft entries is a bit controversial because we might clash with other peoples software, this is not really what we would like to see.

@blueicehaller
Copy link
Author

blueicehaller commented Sep 22, 2022

Hi @MBaesken ,
I assume that either Oracle Java or SAPMachine is installed.
Oracle Java is meanwhile not free for Corporate usage.

Before setting the registry entries I proposed the SAPMachine installer need to check if the value is not set or ask what to do.

@blueicehaller
Copy link
Author

blueicehaller commented Jan 9, 2025

HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft is not under responsibility of SAP/SAPMachine.
Therefore you don't modify it.

kaikramer/keystore-explorer#292 (comment)

...
The next release of KSE will come with a new launcher that also checks for the JAVA_HOME environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question rfe Request for Enhancement sapmachineonly Issues/changes affecting only SapMachine
Projects
None yet
Development

No branches or pull requests

3 participants