Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] add container args #145

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[FEAT] add container args #145

merged 2 commits into from
Oct 15, 2024

Conversation

skrishnan-sap
Copy link
Contributor

@skrishnan-sap skrishnan-sap commented Oct 15, 2024

CHANGES:

  • added args to containers (includes CRD changes)
  • added an environment variable CAPOP_TENANT_MTXS_OPERATION for tenant operations to supply the mtxs command. All tenant operation related environment variables, including subscription payload, are now available in the corresponding initContainers

Controller image for testing: ghcr.io/pavan-sap/cap-operator/controller:0.11.0

- use cds-mtx command as entrypoint/command in tenant operation container
- simplify args usage
Copy link

sonarcloud bot commented Oct 15, 2024

Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the latest image. Looks good 👍

@Pavan-SAP Pavan-SAP merged commit b363b96 into main Oct 15, 2024
5 checks passed
@Pavan-SAP Pavan-SAP deleted the add-args branch October 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants