Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add documentation for the transformServiceBindingToClientCredentialsDestination function #1949

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tomfrenken
Copy link
Member

@tomfrenken tomfrenken commented Nov 20, 2024

What Has Changed?

This PR describes how to use the newly implemented transformServiceBindingToClientCredentialsDestination function.

Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

@@ -200,6 +200,44 @@ The SAP Cloud SDK provides a default implementation for the transformation of se

The default implementation also retrieves a service token, if needed.

Additionally, we provide a default implementation for the transformation of service bindings to OAuth2ClientCredentials destinations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Additionally, we provide a default implementation for the transformation of service bindings to OAuth2ClientCredentials destinations.
Additionally, we provide a function to transform service bindings into OAuth2ClientCredentials destinations, assuming the service binding follows the structure outlined below:

@@ -200,6 +200,44 @@ The SAP Cloud SDK provides a default implementation for the transformation of se

The default implementation also retrieves a service token, if needed.

Additionally, we provide a default implementation for the transformation of service bindings to OAuth2ClientCredentials destinations.

It assumes that your service binding is of the following structure:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It assumes that your service binding is of the following structure:

}
```

If your service URL is not in the `url` property, you can alternatively provide a `url` property as part of the `options` object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If your service URL is not in the `url` property, you can alternatively provide a `url` property as part of the `options` object.
If the service URL is not specified in the `url` property, it can alternatively be provided as part of the `options` parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants