-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add documentation for the transformServiceBindingToClientCredentialsDestination function #1949
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions.
@@ -200,6 +200,44 @@ The SAP Cloud SDK provides a default implementation for the transformation of se | |||
|
|||
The default implementation also retrieves a service token, if needed. | |||
|
|||
Additionally, we provide a default implementation for the transformation of service bindings to OAuth2ClientCredentials destinations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, we provide a default implementation for the transformation of service bindings to OAuth2ClientCredentials destinations. | |
Additionally, we provide a function to transform service bindings into OAuth2ClientCredentials destinations, assuming the service binding follows the structure outlined below: |
@@ -200,6 +200,44 @@ The SAP Cloud SDK provides a default implementation for the transformation of se | |||
|
|||
The default implementation also retrieves a service token, if needed. | |||
|
|||
Additionally, we provide a default implementation for the transformation of service bindings to OAuth2ClientCredentials destinations. | |||
|
|||
It assumes that your service binding is of the following structure: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It assumes that your service binding is of the following structure: |
} | ||
``` | ||
|
||
If your service URL is not in the `url` property, you can alternatively provide a `url` property as part of the `options` object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your service URL is not in the `url` property, you can alternatively provide a `url` property as part of the `options` object. | |
If the service URL is not specified in the `url` property, it can alternatively be provided as part of the `options` parameter. |
What Has Changed?
This PR describes how to use the newly implemented
transformServiceBindingToClientCredentialsDestination
function.