fix(linter/html): Fix glob pattern to match HTML files

Incorrect use of the group syntax {} without another group lead to the pattern never matching anything. Same behavior can be reproduced in local zsh, so likely no UI5 FS bug either. Enhanced project fixture to actually test this linter end-to-end.
SAP · Sep 12, 2024 · 18d80af · 18d80af
1 parent 13a8e2a
commit 18d80af
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/src/linter/html/linter.ts b/src/linter/html/linter.ts
@@ -18,7 +18,7 @@ export default async function lintHtml({workspace, context}: LinterParameters) {
 			htmlResources.push(resource);
 		}));
 	} else {
-		htmlResources = await workspace.byGlob("**/{*.html}");
+		htmlResources = await workspace.byGlob("**/*.html");
 	}
 
 	await Promise.all(htmlResources.map(async (resource: Resource) => {

diff --git a/test/fixtures/linter/projects/com.ui5.troublesome.app/webapp/test/testsuite.qunit.html b/test/fixtures/linter/projects/com.ui5.troublesome.app/webapp/test/testsuite.qunit.html
@@ -8,6 +8,12 @@
 		<title>QUnit test suite for the UI5 Application: com.ui5.troublesome.app</title>
 		<script src="../resources/sap/ui/qunit/qunit-redirect.js"></script>
 		<script src="testsuite.qunit.js" data-sap-ui-testsuite></script>
+
+		<script>
+			sap.ui.require([], async function () {
+				console.log("Hello")
+			});
+		</script>
 	</head>
 	<body></body>
 </html>
diff --git a/test/lib/linter/snapshots/linter.ts.md b/test/lib/linter/snapshots/linter.ts.md
@@ -727,6 +727,24 @@ Generated by [AVA](https://avajs.dev).
         messages: [],
         warningCount: 0,
       },
+      {
+        coverageInfo: [],
+        errorCount: 0,
+        fatalErrorCount: 0,
+        filePath: 'webapp/test/testsuite.qunit.html',
+        messages: [
+          {
+            column: 3,
+            fatal: undefined,
+            line: 12,
+            message: 'Use of unsafe inline script',
+            messageDetails: 'Content Security Policy (https://ui5.sap.com/#/topic/fe1a6dba940e479fb7c3bc753f92b28c)',
+            ruleId: 'ui5-linter-csp-unsafe-inline-script',
+            severity: 1,
+          },
+        ],
+        warningCount: 1,
+      },
       {
         coverageInfo: [
           {

diff --git a/test/lib/linter/snapshots/linter.ts.snap b/test/lib/linter/snapshots/linter.ts.snap