-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add documentation for all available rules #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM, but in the last bullet point in the commit message, I would say "Add ruleId
to Markdown" (the addtl. "name" looks somewhat redundant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions, otherwise fine.
I'll do an interactive rebase to combine the changes into two commits (docs + markdown formatter). |
Co-authored-by: Florian Vogt <florian.vogt@sap.com> Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
The `ruleId` links to the corresponding rule documentation.
To align with naming convention.
5d28da8
to
e484d0c
Compare
Ready for final review. |
JIRA: CPOUI5FOUNDATION-958