Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-menu-item]:Support Other Icon Font #11169

Closed
1 task done
didiaibiancheng opened this issue Mar 25, 2025 · 2 comments
Closed
1 task done

[ui5-menu-item]:Support Other Icon Font #11169

didiaibiancheng opened this issue Mar 25, 2025 · 2 comments

Comments

@didiaibiancheng
Copy link

Feature Request Description

Currently ui5 menu item has icon properties, but it only support SAP-icons font, we are using FPA-icons font now, How can I make FPA-icons display in ui5 menu item?
Image

Proposed Solution

A feasible way to display FPA-icons in V1 ui5-menu-item or a new feature supporting this.

Proposed Alternatives

No response

Organization

sap

Additional Context

No response

Priority

High

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@s-todorova s-todorova self-assigned this Mar 25, 2025
@s-todorova
Copy link
Contributor

s-todorova commented Mar 25, 2025

Hello @didiaibiancheng,

For icons that are not part of the officially supported ui5 icon packages, we suggest using the approach of registering custom SVG icon collections via the registerIconLoader API we provide. You can read more about how to do it in the official documentation.

Setting Medium priority as this is not a full stopper.

@SAP/ui5-webcomponents-core, I see such a request has already been made with #10083, which has been marked as planned, but no updates regarding the status of the decision for such a feature request are provided in the ticket. So tagging you to decide how to handle this.

Best regards,
Siyana

@nnaydenow
Copy link
Contributor

nnaydenow commented Apr 1, 2025

Hello @didiaibiancheng,

Thank you for your request! Unfortunately, we don’t have plans to include FPA icons in our offering or any other LoB-specific icon collections.

I’d recommend following the approach mentioned in #10083: mirroring our icon package structure, reusing our icons build process, and publishing the built icon modules on NPM so they can be shared across SAP SAC teams. This solution, similar to the one proposed by @s-todorova, should help achieve your goal and it is feasible for v1.

Let us know if you need any guidance in this process.

Best regards,
Nayden

@github-project-automation github-project-automation bot moved this from New to Completed in Maintenance - Topic Core Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

No branches or pull requests

4 participants