From f0633fcdb2fe295b9d013cf9343f1bb9c282e526 Mon Sep 17 00:00:00 2001 From: fazledyn-or Date: Tue, 5 Dec 2023 15:19:57 +0600 Subject: [PATCH 1/2] Replaced `NotImplementedError` with `NotImplemented` Signed-off-by: fazledyn-or --- SCons/Variables/ListVariable.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/SCons/Variables/ListVariable.py b/SCons/Variables/ListVariable.py index bfa48f5ebe..a0640e6340 100644 --- a/SCons/Variables/ListVariable.py +++ b/SCons/Variables/ListVariable.py @@ -70,22 +70,22 @@ def __init__(self, initlist=None, allowedElems=None) -> None: self.allowedElems = sorted(allowedElems) def __cmp__(self, other): - raise NotImplementedError + return NotImplemented def __eq__(self, other): - raise NotImplementedError + return NotImplemented def __ge__(self, other): - raise NotImplementedError + return NotImplemented def __gt__(self, other): - raise NotImplementedError + return NotImplemented def __le__(self, other): - raise NotImplementedError + return NotImplemented def __lt__(self, other): - raise NotImplementedError + return NotImplemented def __str__(self) -> str: if not len(self): From cd2abea98da9246a8202227173c4c5782b6ba0e7 Mon Sep 17 00:00:00 2001 From: fazledyn-or Date: Wed, 6 Dec 2023 11:25:56 +0600 Subject: [PATCH 2/2] Added blurb to CHANGES & RELEASE Signed-off-by: fazledyn-or --- CHANGES.txt | 4 ++++ RELEASE.txt | 5 ++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index c0c8ed7eb2..5a9d9e345a 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -15,6 +15,10 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER - Fix of the --debug=sconscript option to return exist statements when using return statement with stop flag enabled + From Ataf Fazledin Ahamed: + - Use of NotImplemented instead of NotImplementedError for special methods + of _ListVariable class + RELEASE 4.6.0 - Sun, 19 Nov 2023 17:22:20 -0700 From Max Bachmann: diff --git a/RELEASE.txt b/RELEASE.txt index c9da8152c3..7599d43fd0 100644 --- a/RELEASE.txt +++ b/RELEASE.txt @@ -38,9 +38,8 @@ FIXES IMPROVEMENTS ------------ -- List improvements that wouldn't be visible to the user in the - documentation: performance improvements (describe the circumstances - under which they would be observed), or major code cleanups +- Use of NotImplemented instead of NotImplementedError for special methods + of _ListVariable class PACKAGING ---------