Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an opt-out and opt-in feature for pinging you when your line quivers #65

Closed
Peter-developer01 opened this issue Sep 5, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Peter-developer01
Copy link
Contributor

So I've been reviewing my inbox and I see there:

  • posts from Charcoal HQ (I did opt-in manually);
  • a comments, replies, or posts from people who noticed my own;
  • and your Utility Bot's "your fish is ready!".

It was fun in the first times. However when you start to see so much "your fish is ready!" items, this is starting to be annoying.


I'm requesting a new command that would allow me to opt-in or opt-out the fish pings.

For example,

  • the command for opt-out would be something like "optout fishpings";
  • the command for opt-in would be something like "optin fishpings".

You can store the config for each user in the, for example, JSON file. You can of course select any file format you like.
And remember, to avoid the confusion, you store the keys as user IDs, not user names.

@PlaceReporter99
Copy link
Collaborator

Storing the user IDs would be impossible. I’ll store the usernames instead. A text file containing those who opted out should be enough. I’ll have to use os.system to commit the changes while the program is running.

@PlaceReporter99 PlaceReporter99 added the enhancement New feature or request label Sep 5, 2023
@Peter-developer01
Copy link
Contributor Author

Why you can't store the user IDs? Storing usernames would be a bad idea because two users can have same usernames, chat allows it.

@PlaceReporter99
Copy link
Collaborator

OakBot sends messages with the usernames, not the user IDs. It would be impossible to tell whether (for example) it was user with an ID of 1 or user with an ID of 2.

@Peter-developer01
Copy link
Contributor Author

Ah, thanks. No better variant to store this then.

@Peter-developer01
Copy link
Contributor Author

Also, don't forget to make an command to opt-in the pings, if the user wants.

@PlaceReporter99
Copy link
Collaborator

I am testing an implementation

@PlaceReporter99 PlaceReporter99 added the paused Work on this has been paused label Sep 9, 2023
@PlaceReporter99 PlaceReporter99 removed the paused Work on this has been paused label Apr 28, 2024
@PlaceReporter99
Copy link
Collaborator

I’m adding a database to this, the command will be setting fishping false to opt out. You will be opted out by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants