Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old forum links without sub-domain fail in a 404 #148

Open
eXpl0it3r opened this issue Nov 2, 2021 · 4 comments
Open

Old forum links without sub-domain fail in a 404 #148

eXpl0it3r opened this issue Nov 2, 2021 · 4 comments

Comments

@eXpl0it3r
Copy link
Member

Old forum links didn't point to the en.* sub-domain and as such will end up in a 404 page.

Example: http://www.sfml-dev.org/forum/viewtopic.php?p=36365#36365

@eXpl0it3r eXpl0it3r added the bug label Nov 2, 2021
@tverrbjelke
Copy link
Contributor

tverrbjelke commented Jan 11, 2023

What would the proper new link be? Simply http-> https and www->en subdomaining does not do the trick.
like from Cannot draw text, linker errors in debug mode, other in rls

Has this link:
http://www.sfml-dev.org/forum/viewtopic.php?p=36365#36365

https://en.sfml-dev.org/forum/viewtopic.php?p=36365#36365
Not sure what a "correct link" would be like.

@eXpl0it3r
Copy link
Member Author

eXpl0it3r commented Jan 11, 2023

The new forum is at forums/ and it uses index.php for all the posts.
But even this doesn't work: https://en.sfml-dev.org/forums/index.php?topic=36365

I don't know exactly what the solution would be for it. I am hoping that there's a way to match this somehow in the database.

@tverrbjelke
Copy link
Contributor

I see SFML uses https://wiki.simplemachines.org/smf/SMF2.0:Main_Page. I
ll have a look into the installation and Database thing. Maybe I can dig slowly through it and understand what to do.

  • You migrated from one old version to 2.0x of SMF?
  • You just changed the domain -> subdomain of the forum?

It will take some time for me (real live is happening in realtime), but who knows... mabye it's an easy fix.

@eXpl0it3r
Copy link
Member Author

eXpl0it3r commented Jan 15, 2023

I just had another peek at the forum data and it doesn't seem like an easy redirect will do, because the ID in http://www.sfml-dev.org/forum/viewtopic.php?p=<id> refers to the message ID itself, which is different from the topic ID. But the new system doesn't have an "message ID" URL.

As such, we'll need to either have to write a viewtopic script that fetches the topic for a given message ID and builds a new URL, or consider replacing all the links in the database, so at least the forum in itself would be consistent, even if external links would still break.

Example:

https://en.sfml-dev.org/forums/index.php?topic=460.msg4458#msg4458 mentions http://www.sfml-dev.org/forum/viewtopic.php?p=4440#4440 which actually refers to this post: https://en.sfml-dev.org/forums/index.php?topic=676.msg4440#msg4440
Not the .msg4440#msg4440 at the end of the URL, but without the preceding topic ID 676, the link doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants