Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Paper query #131

Closed
EmilyBourne opened this issue Aug 19, 2024 · 1 comment
Closed

[JOSS] Paper query #131

EmilyBourne opened this issue Aug 19, 2024 · 1 comment

Comments

@EmilyBourne
Copy link

Regarding openjournals/joss-reviews#7018 I have a quick question. I don't know if there is a mistake in the paper or if I have simply misunderstood as I am unfamiliar with the sparse grid combination technique.

In the paper you state that the figure shows a scheme with 5 component grids but this does not seem to be reflected in the diagram. Depending on what is meant by a component grid I would expect there to be either 7, 4, or 3.
image

Perhaps you meant to use the adjacent figure from the thesis:
image

?

@freifrauvonbleifrei
Copy link
Contributor

@EmilyBourne yes, you are right, thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants