Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests needed #3

Closed
2 of 8 tasks
yinleon opened this issue Sep 27, 2018 · 2 comments
Closed
2 of 8 tasks

Tests needed #3

yinleon opened this issue Sep 27, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yinleon
Copy link
Collaborator

yinleon commented Sep 27, 2018 •
edited
Loading

Hi we need a test for:

  • search

  • get_captions

  • get_playlists

  • get_videos_from_playlist

  • get_subscriptions

  • get_featured_channels

  • get_video_captions

  • get_recommended_videos

Search has a lot of arguments, and get_captions does not use the API!
@yinleon yinleon added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 27, 2018
@yinleon
Copy link
Collaborator Author

yinleon commented Nov 22, 2018

This is a topic that needs revisiting.
Thanks to @Michael98Liu for writing up how tests and travis work.

The current tests are incomplete or don't cover enough of the functions.
For example, test_video_methods does not actually test anything.
Also need to figure out whose key is being used in Travis.

@mabrownnyu
Copy link
Collaborator

Closed because replaced with #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yinleon @mabrownnyu