Fix semantics of empty blocks and implement basic interpreter tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
Apparently, we hadn’t implemented those before. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
The tests cause GC to trigger, which isn’t currently working perfectly. Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
uninitialized-locals
branch
from
19db9a8 to
bca214a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that empty blocks return
nil, see: SOM-st/SOM#54.In order to test this, I also needed to implement the basic interpreter tests, which apparently hasn't been done before.
To avoid issues with CPPUNIT, I'll switch Travis CI to Ubuntu 20.04, which has cppunit in a version that supports parameterized unit tests.