[FEAT] 리뷰 api 연결 #91
Merged
[FEAT] 리뷰 api 연결 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taew00k
reviewed
Nov 28, 2024
There was a problem hiding this comment.
tanstack query 잘 적용해주신 것 같아요 👍👍
|
예림님 리뷰하면서 저도 tanstack-query 찾아보면서 개념 정리를 할 수 있었던 것 같아요 2주간 고생 많으셨습니다~~!! |
seong-hui
approved these changes
Nov 28, 2024
| import instance from '@apis/instance'; | ||
| import { AxiosError } from 'axios'; | ||
|
|
||
| export interface Review { |
| const { data, isError } = useReviewQueries({ productId }); | ||
|
|
||
| if (isError) { | ||
| console.error(isError); |
There was a problem hiding this comment.
isError는 정말 에러인지 아닌지 true, false의 값만 가지고 있어서 해당 부분에서 true라는 콘솔이 찍히게 됩니다! 따라서 콘솔에서 구체적인 에러 메세지를 확인하고 싶다면 error를 받아와서 콘솔에 찍어와 주셔야 할 것 같아요!
There was a problem hiding this comment.
오! 그렇군요!! 반영 완료했습니다!
| @@ -1,128 +1,7 @@ | |||
| import reviewImage from '@assets/images/img_review_4.png'; // 이미지 import | |||
There was a problem hiding this comment.
아 요거 나중에 서버 끊기면 더미 데이터로 화면 띄워두려고 남겨둘려고 했는데 남겨주는 건 어떨까욤,,?
There was a problem hiding this comment.
아! 남기는 것으로 수정하겠습니당!! 오홍
복구 완료 했습니다! import는 불러오기는 이름이 중복되서 나중에 서버 끊기면 갈아끼우겠솜당~
bykbyk0401
approved these changes
Nov 29, 2024
| import { getReview, GetReviewResponse } from './getReview'; | ||
|
|
||
| const useReviewQueries = ({ productId }: { productId: number }) => { | ||
| const QUERY_KEY = { |
There was a problem hiding this comment.
이렇게 QUERY_KEY를 만들기도 하는군요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 🛰️
작업 내용 🧑💻
알게된 점 🚀
깃허브 pr단에서 build에러를 잡을 수 있다는 것을 새롭게 알게되었습니다!
build에러도 확인하고 머지하겠습니당!!
스크린샷 📸
2024-11-29.1.04.51.mov