Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AssertionError in PillarboxMediaMetaDataTrackerTest #848

Open
MGaetan89 opened this issue Jan 6, 2025 · 0 comments
Open

Fix AssertionError in PillarboxMediaMetaDataTrackerTest #848

MGaetan89 opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MGaetan89
Copy link
Member

As a Pillarbox developer, I want to be able to run the project's tests with confidence.

Context

From time to time, the PillarboxMediaMetaDataTrackerTest > chapter transition after seek back fails because we don't receive the expected values.
Here's the stacktrace:

PillarboxMediaMetaDataTrackerTest > chapter transition after seek back FAILED
    java.lang.AssertionError: expected:<[Chapter(id=Chapter3, start=2000, end=5000, mediaMetadata=androidx.media3.common.MediaMetadata@743fcd71), null, Chapter(id=Chapter3, start=2000, end=5000, mediaMetadata=androidx.media3.common.MediaMetadata@743fcd71), null, Chapter(id=Chapter4, start=10000, end=15000, mediaMetadata=androidx.media3.common.MediaMetadata@743fcd71), null]> but was:<[Chapter(id=Chapter3, start=2000, end=5000, mediaMetadata=androidx.media3.common.MediaMetadata@743fcd71), null, Chapter(id=Chapter3, start=2000, end=5000, mediaMetadata=androidx.media3.common.MediaMetadata@743fcd71), Chapter(id=Chapter4, start=10000, end=15000, mediaMetadata=androidx.media3.common.MediaMetadata@743fcd71), null]>
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:120)
        at kotlin.test.junit.JUnitAsserter.assertEquals(JUnitSupport.kt:32)
        at kotlin.test.AssertionsKt__AssertionsKt.assertEquals(Assertions.kt:63)
        at kotlin.test.AssertionsKt.assertEquals(Unknown Source)
        at kotlin.test.AssertionsKt__AssertionsKt.assertEquals$default(Assertions.kt:62)
        at kotlin.test.AssertionsKt.assertEquals$default(Unknown Source)
        at ch.srgssr.pillarbox.player.tracker.PillarboxMediaMetaDataTrackerTest.chapter transition after seek back(PillarboxMediaMetaDataTrackerTest.kt:96)

Acceptance criteria

  • PillarboxMediaMetaDataTrackerTest > chapter transition after seek back behave consistently across multiple executions.
@MGaetan89 MGaetan89 converted this from a draft issue Jan 6, 2025
@MGaetan89 MGaetan89 self-assigned this Jan 6, 2025
@MGaetan89 MGaetan89 added the bug Something isn't working label Jan 6, 2025
@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Jan 6, 2025
@MGaetan89 MGaetan89 added this to the Test milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚧 In Progress
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant