Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when spritesheet can't be downloaded. #893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't crash when spritesheet can't be downloaded. #893

wants to merge 1 commit into from

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

Fix a crash when spritesheet url can't be downloaded.

Changes made

  • When the sprite sheet url can't be downloaded the player behaves like it is done if the bitmap can't be decoded. If the sprite sheet track is selected nothing happens since there is no data.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Feb 12, 2025 that may be closed by this pull request
Don't crash if the sprite sheet can't be downloaded #892
Open
@StaehliJ StaehliJ requested a review from MGaetan89 February 12, 2025 13:53
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 51.2% -0.02% 🟢
Files changed 88.46% 🟢

Module Coverage
:pillarbox-core-business 81.41% -0.09% 🟢
Files
Module File Coverage
:pillarbox-core-business SpriteSheetMediaPeriod.kt 42.69% -1.37% 🟢

MGaetan89
MGaetan89 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easy to add some tests here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✏️ Draft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't crash if the sprite sheet can't be downloaded
2 participants
@StaehliJ @MGaetan89