Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monitoring data format #269

Closed
1 task
defagos opened this issue Sep 23, 2024 · 1 comment · Fixed by #267
Closed
1 task

Update monitoring data format #269

defagos opened this issue Sep 23, 2024 · 1 comment · Fixed by #267
Assignees
Labels
enhancement New feature or request released on @main
Milestone

Comments

@defagos
Copy link
Member

defagos commented Sep 23, 2024

As a QoS backend developer I need data to be provided by clients in the format that was agreed upon.

Hints

See SRGSSR/pillarbox-documentation#97.

Acceptance criteria

  • Frame drops are provided if available.
  • Constants are uppercase.

Tasks

  • ...
@defagos defagos converted this from a draft issue Sep 23, 2024
@defagos defagos moved this from ✏️ Draft to 📋 Backlog in Pillarbox Sep 23, 2024
@defagos defagos added the enhancement New feature or request label Sep 23, 2024
@defagos defagos added this to the QoS milestone Sep 23, 2024
@defagos defagos changed the title Implement most recent monitoring specs Update monitoring data format Sep 23, 2024
amtins added a commit that referenced this issue Sep 24, 2024
Resolves #269, sending the number of frame drops during the media playback
session.

- adds `frame_drops` property
- adds the `getVideoPlaybackQuality` function to the player mock
@defagos defagos moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Sep 30, 2024
@MGaetan89 MGaetan89 linked a pull request Oct 4, 2024 that will close this issue
amtins added a commit that referenced this issue Oct 14, 2024
Resolves #269, sending the number of frame drops during the media playback
session.

- adds `frame_drops` property
- adds the `getVideoPlaybackQuality` function to the player mock
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Oct 14, 2024
github-actions bot pushed a commit that referenced this issue Oct 14, 2024
## [1.14.0](v1.13.1...v1.14.0) (2024-10-14)

### Enhancements and Bug Fixes 🐛

* **pillarbox-monitoring:** invalid service URL ([acf45d4](acf45d4))
* **pillarbox-monitoring:** update endpoint url ([2b31e9b](2b31e9b))
* **pillarbox-monitoring:** use capital case to align with spec ([4778d43](4778d43))

### New Features 🚀

* add playback monitoring ([e867456](e867456)), closes [#262](#262)
* **pillarbox-monitoring:** add frame drops ([ec67109](ec67109)), closes [#269](#269)

### Tests ✅

* rename test/analytics folder to test/trackers ([d1c85c2](d1c85c2))
Copy link

🎉 This issue has been resolved in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @main
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants