-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Develop the Breadcrumbs Component with Final Node Customization #3326
Comments
This is pretty close to done, waiting for Caleb to do some of the harder parts as he would rather we go through it together (conditional collection displayed on /consulting). Working on the simple parts of #3316 (ex. schema) in the meantime. |
I've implemented the design and had it test passed by Betty and Louis, but unfortunately I needed to fix some bugs related to the traffic splitting for the new and old consulting pages so this won't be ready before for sprint review. Also the linter is flagging "dark" as a non-tailwind class despite it being one https://tailwindcss.com/docs/dark-mode#toggling-dark-mode-manually |
I haven't requested a test please yet because the playwright test for broken images was failing. The reason it's failing is because not all of the consulting pages are being generated with the new route splitting method. I found this out because I could see that next JS was failing to pre-fetch the data for the routes on the consulting index page. The reason the pages aren't being generated is that Tina's graphql client only returns the first 50 results for a particular query (unless overridden) and we have 94 consulting pages. I've fixed this issue and am currently unsure why the consulting pages still aren't being generated. |
cc @wicksipedia @isaaclombardssw @UlyssesMaclaren @adamcogan @miichaelsmedley @louisroa8189
Description:
Create the Breadcrumbs component for Consulting Pages to display a clear navigation hierarchy. The component should use the page title as the default final node, which should not be clickable. Customization options should allow users to edit the final node for SEO or usability purposes, with the ability to reset to the default.
Acceptance Criteria
Tasks
Figure: Breadcrumbs
The text was updated successfully, but these errors were encountered: