Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor applications based on new components #474

Closed
5 of 10 tasks
antoineatstariongroup opened this issue Oct 10, 2023 · 0 comments · Fixed by #531
Closed
5 of 10 tasks

Refactor applications based on new components #474

antoineatstariongroup opened this issue Oct 10, 2023 · 0 comments · Fixed by #531
Assignees
@joao4all
Labels
COMET Web App enhancement New feature or request ?sp

Comments

@antoineatstariongroup
Copy link
Contributor

antoineatstariongroup commented Oct 10, 2023 •
edited by joao4all
Loading

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the COMET-WEB
  • I have searched open and closed issues to ensure it has not already been reported

Description

SingleEngineeringModelApplicationBase and ApplicationBase components have been implemented in #473

  • List all implemented applications that do not rely on one Iteration (example : BookApplication only needs EngineeringModel data)
  • Align all applications with the new template

Remark :
ViewModels of Body have to be aligned also. Removed every unnecessary methods like OnIterationChanged, OnDomainChanged, ...

Steps to Reproduce

Logs

  • There are no logs regarding the issue
  • I have attached a log file or included the relevant section in this issue

System Configuration

  • COMET version:
    • COMET-WEB:
    • Other:
  • Web Services:
    • COMET Web Services version:
@joao4all joao4all self-assigned this Mar 12, 2024
@joao4all joao4all mentioned this issue Mar 13, 2024
Merged
4 tasks
joao4all added a commit that referenced this issue Mar 13, 2024
@joao4all
Feat #474 Refactor applications based on new components (#531)
e6db00e 
* applications from server refactored
* fixed null CurrentThing for SingleEngineeringModelApplicationBaseViewModel
* element definition and user managment view models updated to use IHaveReusableRows
@samatstariongroup samatstariongroup moved this to Done in COMET-WEB Jul 17, 2024
@samatstariongroup samatstariongroup moved this to Done in COMET-CE Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joao4all joao4all

Labels
COMET Web App enhancement New feature or request ?sp
Projects
COMET-CE
Archived in project
COMET-WEB
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat #474 Refactor applications based on new components STARIONGROUP/COMET-WEB-Community-Edition
2 participants
@antoineatstariongroup @joao4all