[WIP] MultiModelEditor; fixes #733; fixes #734 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samatstariongroup
requested changes
Dec 20, 2024
| await this.session.Write(transaction.FinalizeTransaction()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
new line at end of each file please
| @@ -222,6 +222,11 @@ public virtual async Task<Result<Iteration>> OpenSession() | |||
| return Result.Fail(["The selected iteration and the domain of expertise should not be null"]); | |||
| } | |||
|
|
|||
| if (this.sessionService.OpenIterations.Items.Any(x => x.IterationSetup.Iid == this.SelectedIterationSetup.IterationSetupId)) | |||
| { | |||
| return Result.Fail(["The selected iteration is already openened"]); | |||
There was a problem hiding this comment.
what happens for the user? if the user should not be able to select an iteration that is already open, lets prevent them from doing so. The feedback message can stay.
| { | ||
| await this.OnDragEnd.InvokeAsync((this, node)); | ||
| await this.OnCalculateDropIsAllowed.InvokeAsync(this); | ||
| Console.WriteLine("DragEnd"); |
There was a problem hiding this comment.
can these be implemented using a logging framework ?
| @@ -103,6 +104,16 @@ private static List<Application> InitializesApplications() | |||
| ComponentType = typeof(ElementDefinitionTable) | |||
| }, | |||
|
|
|||
| new TabbedApplication | |||
| { | |||
| Name = "Multi Model Editor", | |||
There was a problem hiding this comment.
please change name to Model Editor and this one needs to replace the existing one
| @@ -126,6 +126,11 @@ public static class WebAppConstantValues | |||
| /// </summary> | |||
| public const string ModelEditorPage = "ModelEditor"; | |||
There was a problem hiding this comment.
if this is the old one, i propose we replace it with the new one
samatstariongroup
requested changes
Dec 20, 2024
| /// The shortname of the owning <see cref="DomainOfExpertise" /> | ||
| /// </summary> | ||
| public string OwnerShortName | ||
| { |
lxatstariongroup
force-pushed
the
feat/gh733-and-gh734-MultiModelEditor
branch
from
3495dfc to
a649e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
MultiModelEditor; fixes #733; fixes #734