Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Assembler.TryGetReferencedElement - hack #60

Closed
samatstariongroup opened this issue Nov 12, 2024 · 2 comments
Closed

[Refactor] Assembler.TryGetReferencedElement - hack #60

samatstariongroup opened this issue Nov 12, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@samatstariongroup
Copy link
Member

@nathanatstariongroup I had to refactor the code below to make it work. This is a bit of a hack, can you clean this up?

https://github.com/STARIONGROUP/uml4net/blame/5b871f73ab4d483428cd69013a5c4f317568ab98/uml4net.xmireader/Cache/Assembler.cs#L127
@samatstariongroup samatstariongroup added the help wanted Extra attention is needed label Nov 12, 2024
nathanatstariongroup pushed a commit that referenced this issue Nov 12, 2024
[FIX] #60
048bfb1
nathanatstariongroup added a commit that referenced this issue Nov 14, 2024
@nathanatstariongroup
[FIX] #60 (#61)
7d13d92 
* [FIX] #60
@samatstariongroup
Copy link
Member Author

@nathanatstariongroup can this be closed?

@nathanatstariongroup
Copy link
Contributor

closed by #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samatstariongroup @nathanatstariongroup