diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml deleted file mode 100644 index 949cfd4..0000000 --- a/.github/workflows/firebase-hosting-pull-request.yml +++ /dev/null @@ -1,17 +0,0 @@ -# This file was auto-generated by the Firebase CLI -# https://github.com/firebase/firebase-tools - -name: Deploy to Firebase Hosting on PR -'on': pull_request -jobs: - build_and_preview: - if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}' - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - run: npm ci && npm run build - - uses: FirebaseExtended/action-hosting-deploy@v0 - with: - repoToken: '${{ secrets.GITHUB_TOKEN }}' - firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_SU_MAINWEB }}' - projectId: su-mainweb diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml new file mode 100644 index 0000000..e8dd2dd --- /dev/null +++ b/.github/workflows/pull-request.yml @@ -0,0 +1,49 @@ +# This file was auto-generated by the Firebase CLI +# https://github.com/firebase/firebase-tools + +name: Deploy to Firebase Hosting on PR +on: pull_request +jobs: + build_and_preview: + name: 'Build web and deploy preview' + if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}' + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - run: npm ci && npm run build + - uses: FirebaseExtended/action-hosting-deploy@v0 + id: action-hosting-deploy + with: + repoToken: '${{ secrets.GITHUB_TOKEN }}' + firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_SU_MAINWEB }}' + projectId: su-mainweb + outputs: + urls: ${{ steps.action-hosting-deploy.outputs.urls }} + lighthouse: + name: 'Run lighthouse check on preview' + runs-on: ubuntu-latest + needs: build_and_preview + steps: + - uses: actions/checkout@master + - run: mkdir -p ${{ github.workspace }}/tmp/artifacts + - name: Lighthouse + uses: foo-software/lighthouse-check-action@master + id: lighthouseCheck + with: + urls: ${{ fromJson(needs.build_and_preview.outputs.urls)[0] }} + gitHubAccessToken: '${{ secrets.GITHUB_TOKEN }}' + prCommentEnabled: true + outputDirectory: ${{ github.workspace }}/tmp/artifacts + - name: Upload lighthouse report + uses: actions/upload-artifact@master + with: + name: Lighthouse reports + path: ${{ github.workspace }}/tmp/artifacts + - name: Verify Lighthouse Check results + uses: foo-software/lighthouse-check-status-action@master + with: + lighthouseCheckResults: ${{ steps.lighthouseCheck.outputs.lighthouseCheckResults }} + minAccessibilityScore: '50' + minBestPracticesScore: '50' + minPerformanceScore: '50' + minSeoScore: '50' diff --git a/src/components/organisms/Footer.astro b/src/components/organisms/Footer.astro index 0aa9609..58632d0 100644 --- a/src/components/organisms/Footer.astro +++ b/src/components/organisms/Footer.astro @@ -51,9 +51,7 @@ import { SuLogo } from '../atoms/SuLogo';