Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checking of buttons props on MoleculeNotification ✨ #2609

Open
jelowin opened this issue Aug 4, 2023 · 0 comments
Open

Improve checking of buttons props on MoleculeNotification ✨ #2609

jelowin opened this issue Aug 4, 2023 · 0 comments
Labels
enhancement

Comments

@jelowin
Copy link
Contributor

jelowin commented Aug 4, 2023 •
edited
Loading

Is your iteration request related to a problem?

On MoleculeNotification component, we have a prop that is an array called buttons and we are not checking buttons.length to show buttons sui-MoleculeNotification-buttonsContainer.

This is causing that, if we pass an empty array, the container is it painted.

Screenshot 2023-08-04 at 11 30 55

Incorrect View
Screenshot 2023-08-04 at 11 30 19

Correct View
Screenshot 2023-08-04 at 11 32 49

Describe the solution you'd like

Screenshot 2023-08-04 at 11 31 32

Screenshot 2023-08-04 at 11 31 51

Screenshots

No response

Additional context**

No response

Additional info

No response
@jelowin jelowin changed the title ✨ Improve checking of buttons props om MoleculeNotification ✨ Aug 4, 2023
@jelowin jelowin changed the title Improve checking of buttons props om MoleculeNotification ✨ Improve checking of buttons props on MoleculeNotification ✨ Aug 4, 2023
@jelowin jelowin mentioned this issue Oct 26, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelowin