-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atom/input): refactor #2310
Open
andresin87
wants to merge
183
commits into
master
Choose a base branch
from
refactor-atom-input-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
183 commits
Select commit
Hold shift + click to select a range
73a1892
chore(Root): wip
andresin87 063ef49
chore(Root): wip
andresin87 95805b3
feat(components/atom/input): refactor general
andresin87 c311002
docs(Root): remove unnecesary declared prop
andresin87 b4eff42
chore(Root): revert
andresin87 f7835e1
fix(components/molecule/autosuggest): remove padded icon
andresin87 7cf945e
feat(components/atom/input): minor input style mods
andresin87 eb6364a
feat(components/atom/input): mod styles
andresin87 25281c7
feat(components/atom/tag): add 2 sizes and fix styles
andresin87 0974a0d
feat(components/molecule/inputTags): modify the component to addopt tβ¦
andresin87 d747473
chore(components/atom/input): restore package.json
andresin87 43d0db5
chore(components/atom/tag): restore package.json
andresin87 49bff79
chore(components/molecule/inputTags): restore package.json+
andresin87 7daf619
refactor(components/atom/input): remove unnnecesary destructuring
andresin87 5564ebc
refactor(components/atom/input): improve readability oh imask handlers
andresin87 7bfdeb9
refactor(components/atom/input): isValidSize refactor helper
andresin87 a2849bb
refactor(components/atom/input): lint
andresin87 8a89c16
feat(components/molecule/select): get the right input structure
andresin87 7f30eaa
feat(components/molecule/notification): create new variable to defineβ¦
a3eca0e
feat(components/molecule/notification): refactor to use background coβ¦
91ac33b
release(components/molecule/notification): v1.33.0 [skip ci]
sui-bot d505e69
feat(components/molecule/imageEditor): Add a SCSS token to customize β¦
oegea 7ccda3d
release(components/molecule/imageEditor): v1.10.0 [skip ci]
sui-bot f053bd6
feat(components/atom/helpText): add margin top variable
andresz1 b529d89
feat(components/atom/validationText): add margin top variable
andresz1 aa42d3a
feat(components/atom/helpText): update margin variable
andresz1 1550f4f
feat(components/atom/validationText): update margin variable
andresz1 235d983
feat(components/atom/validationText): update margin
andresz1 88ee516
release(components/atom/helpText): v1.8.0 [skip ci]
sui-bot 2e8afdf
release(components/atom/validationText): v1.8.0 [skip ci]
sui-bot c2510da
feat(components/molecule/tabs): Change tabs to be able to modify currβ¦
oegea ae6843c
feat(components/molecule/tabs): control/uncontroll active tabs
andresin87 22d0388
feat(components/molecule/tabs): remove unnecesary prop injected
andresin87 521935f
chore(Root): Update coverage badges
sui-bot f45391e
release(components/molecule/tabs): v2.36.0 [skip ci]
sui-bot 2f67190
fix(components/molecule/drawer): avoid add a listener for keydown thaβ¦
fb17d95
chore(Root): Update coverage badges
sui-bot 53bb8f9
release(components/molecule/drawer): v4.6.0 [skip ci]
sui-bot e61f953
feat(components/molecule/avatar): handle background color for avatar β¦
c818a32
chore(Root): Update coverage badges
sui-bot ebad16c
release(components/molecule/avatar): v1.14.0 [skip ci]
sui-bot 6dcbfee
feat(components/atom/label): add opacity token (#2338)
0a061aa
release(components/atom/label): v1.22.0 [skip ci]
sui-bot 5613efc
feat(components/atom/image): rename node prop
sephoenix 8fbfdc0
release(components/atom/image): v2.14.0 [skip ci]
sui-bot 4162a5b
feat(components/atom/slider): add z-index in tooltip
javiauso 6e74f16
release(components/atom/slider): v1.29.0 [skip ci]
sui-bot c994a8d
feat(components/atom/image): replace cloneElement spinner
sephoenix 98dca3e
chore(Root): Update coverage badges
sui-bot c91c4bf
release(components/atom/image): v2.15.0 [skip ci]
sui-bot 781f2a9
docs(components/atom/skeleton/demo): Update skeleton demo
stefi23 9249284
feat(components/atom/slider): Remove -system
stefi23 53f8cf4
feat(components/atom/tag): Remove -system
stefi23 a559798
feat(components/molecule/notification): Remove -system
stefi23 f164d7b
feat(components/molecule/rating): Remove -system
stefi23 e63d5c2
release(components/atom/slider): v1.30.0 [skip ci]
sui-bot 345844c
release(components/atom/tag): v2.44.0 [skip ci]
sui-bot 66c1eec
release(components/molecule/notification): v1.34.0 [skip ci]
sui-bot 723e3b2
release(components/molecule/rating): v1.21.0 [skip ci]
sui-bot e830159
docs(components/atom/slider): Add AtomSlider marker prop doc
javiauso ab9f769
docs(components/atom/slider): update indent
javiauso 8b7d42f
feat(components/primitive/portal): first approach
80c49cb
test(components/primitive/portal): add tests
andresin87 dd411dc
chore(Root): wip
andresin87 d5bea56
chore(Root): wip
andresin87 efb6d6a
chore(Root): wip
andresin87 494c2b0
chore(Root): wip
andresin87 8b62397
chore(Root): wip
andresin87 15dea5e
chore(Root): wip
andresin87 63a0df9
feat(components/hook/usePortal): first version
andresin87 3433829
chore(Root): Update coverage badges
sui-bot f05a3ed
release(components/hook/usePortal): v1.1.0 [skip ci]
sui-bot 7092f4b
chore(Root): add issue test template
andresin87 006380c
chore(Root): modify the test report
andresin87 4165f4f
refactor(components/molecule/avatar): Replace cloneElement with sui pβ¦
oegea 49ef325
feat(components/molecule/avatar): Add primitive injector dependency
oegea 1d67898
refactor(components/molecule/field): replace cloneElement with injector
oegea f629f63
refactor(components/molecule/buttonGroup): Replace cloneElement with β¦
oegea a3ea487
refactor(components/molecule/buttonGroup): Remove not-needed code
oegea 0644557
refactor(components/molecule/buttonGroup): Remove no-longer needed vaβ¦
oegea 63ab33c
refactor(components/molecule/buttonGroup): Remove no-longer needed fuβ¦
oegea 38d305c
chore(Root): Update coverage badges
sui-bot 64ee2c5
release(components/molecule/avatar): v1.15.0 [skip ci]
sui-bot f88f753
fix(components/atom/image): update proptype
andresin87 bfd81aa
release(components/atom/image): v2.16.0 [skip ci]
sui-bot e7028c0
chore(Root): update the isue templates
andresin87 8269a9a
chore(Root): improve issue reports
andresin87 6c94d08
docs(Root): improve the commit message documentation
andresin87 3cf0f59
chore(Root): update mermaid image sync with node CI workflow
andresin87 5945cb2
feat(components/molecule/dropdownList): replace cloneElement by Injector
sephoenix 28b2018
feat(components/molecule/dropdownList): remove unnecesary code
sephoenix 4008aaa
chore(Root): Update coverage badges
sui-bot 04fd715
release(components/molecule/dropdownList): v1.33.0 [skip ci]
sui-bot de3e0f3
feat(components/molecule/field): refactor Label's conditional in field
sephoenix eaf3bb0
refactor(components/molecule/field): solve conflicts
andresin87 c10fdd6
refactor(components/molecule/avatar): Replace cloneElement by injector
stefi23 ffc926c
fix(components/atom/input): wip
andresin87 f664820
refactor(components/atom/input): Update props order
stefi23 e109437
refactor(components/atom/input): Moved checkIfValidNumberInput to helβ¦
stefi23 d2ad012
chore(Root): Update coverage badges
sui-bot 1924412
release(components/atom/input): v5.22.0 [skip ci]
sui-bot 6dce79f
release(components/molecule/field): v1.35.0 [skip ci]
sui-bot 21adccb
fix(components/molecule/field):less strict label validation
andresin87 b39e18c
refactor(components/molecule/field):lint
andresin87 a96eb82
fix(components/molecule/field): fix lint error
63ff8a9
release(components/molecule/field): v1.36.0 [skip ci]
sui-bot 896d148
docs(Root): upgrade demo versions
andresin87 715fa4d
feat(components/molecule/select): upgrade dropdownOption version
andresin87 3bb8fda
feat(components/molecule/dropdownOption): change prop naming followinβ¦
andresin87 d9d956b
feat(components/molecule/dropdownList): upgrade dropdownOption version
andresin87 2562b85
feat(components/molecule/select): set new prop name following conventβ¦
andresin87 cb99edf
chore(components/molecule/autosuggestField): upgrade versions
andresin87 05b04ef
feat(components/molecule/autosuggest): update the dropdownOption new β¦
andresin87 e9b9e98
chore(Root): Update coverage badges
sui-bot e235220
release(components/molecule/autosuggest): v2.66.0 [skip ci]
sui-bot dedf5c6
release(components/molecule/dropdownList): v2.1.0 [skip ci]
sui-bot 848a9c9
release(components/molecule/dropdownOption): v2.1.0 [skip ci]
sui-bot ceefe2a
release(components/molecule/select): v1.56.0 [skip ci]
sui-bot 7cfe913
Add title props for image component
Ph0tonic 7774c55
Update image component readme
Ph0tonic 9e94f42
Reorder image props
Ph0tonic 15f7a8f
feat(components/atom/helpText): admit react nodes as a text
andresin87 a64059e
feat(components/atom/validationText): admit react nodes as a text
andresin87 7875d15
feat(components/molecule/field): admit react nodes in error alert sucβ¦
andresin87 85b1764
test(components/hook/usePortal): lint sorting imports
andresin87 61c1161
chore(Root): Update coverage badges
sui-bot a665b69
release(components/atom/actionButton): v1.10.0 [skip ci]
sui-bot 7ada81b
release(components/atom/backToTop): v2.3.0 [skip ci]
sui-bot 9f255c8
release(components/atom/badge): v1.28.0 [skip ci]
sui-bot e9f50f7
release(components/atom/card): v1.24.0 [skip ci]
sui-bot 6aadda2
release(components/atom/helpText): v1.9.0 [skip ci]
sui-bot 9dc3d1a
release(components/atom/popover): v3.12.0 [skip ci]
sui-bot 74cbb8b
release(components/atom/progressBar): v2.9.0 [skip ci]
sui-bot 31987ce
release(components/atom/radioButton): v1.10.0 [skip ci]
sui-bot 49f09f4
release(components/atom/skeleton): v1.6.0 [skip ci]
sui-bot fd0a524
release(components/atom/spinner): v2.3.0 [skip ci]
sui-bot 6386d0c
release(components/atom/switch): v1.28.0 [skip ci]
sui-bot e2b4466
release(components/atom/table): v1.14.0 [skip ci]
sui-bot ef5bd24
release(components/atom/textarea): v2.20.0 [skip ci]
sui-bot b83591e
release(components/atom/tooltip): v2.5.0 [skip ci]
sui-bot 8e7aba1
release(components/atom/upload): v3.10.0 [skip ci]
sui-bot e5bcde4
release(components/atom/validationText): v1.9.0 [skip ci]
sui-bot 0ea367d
release(components/behavior/sticky): v1.9.0 [skip ci]
sui-bot 67a98b3
release(components/layout/grid): v2.13.0 [skip ci]
sui-bot 285146a
release(components/molecule/accordion): v2.7.0 [skip ci]
sui-bot 6934afa
release(components/molecule/autosuggestField): v2.11.0 [skip ci]
sui-bot dacd060
release(components/molecule/avatar): v1.16.0 [skip ci]
sui-bot ce11053
release(components/molecule/breadcrumb): v1.27.0 [skip ci]
sui-bot 9ec33f6
release(components/molecule/buttonGroup): v2.10.0 [skip ci]
sui-bot b1a3be2
release(components/molecule/buttonGroupField): v1.9.0 [skip ci]
sui-bot 670b29c
release(components/molecule/checkboxField): v5.1.0 [skip ci]
sui-bot 14c2205
release(components/molecule/field): v1.37.0 [skip ci]
sui-bot c271bd1
docs(Root): put correct links on the homepage of SUI Components
jordevo 3cd9fae
docs(Root): use new URL for bug reporting
jordevo 3b12364
feat(components/atom/popover): add icon color type
andresin87 68f68ef
release(components/atom/popover): v3.13.0 [skip ci]
sui-bot e219204
fix(component/molecule/accordion): The arrows are upside down
najeebkp ff14052
Delete yarn.lock
andresin87 f47735e
fix(component/molecule/accordion): icon transition
najeebkp 5abe5da
feat(components/molecule/dropdownOption): Fixed grammar error
sephoenix 8672798
release(components/molecule/dropdownOption): v2.2.0 [skip ci]
sui-bot 6583031
feat(components/atom/pinInput): create new token to be able to overwrβ¦
Sabri1209 c4b035b
feat(components/atom/pinInput): replace inherit by auto
Sabri1209 c984713
release(components/atom/pinInput): v1.11.0 [skip ci]
sui-bot 3119371
fix(components/molecule/select): accept onblur prop
alfdocimo b497f7e
refactor(components/molecule/select): use explicit naming for event
alfdocimo 1edfc2d
chore(Root): Update coverage badges
sui-bot 9e17687
release(components/molecule/select): v1.57.0 [skip ci]
sui-bot 5021d4e
feat(components/molecule/tabs): make tabs accesibles
oriolpuig 58fa2c8
refactor(components/molecule/tabs): not update activeContent element
oriolpuig 724c10f
feat(components/molecule/tabs): add orientation aria attribute
oriolpuig 8be0ed6
feat(components/molecule/tabs): add id prop to make tabs uniques
oriolpuig 15fc3d7
feat(components/molecule/tabs): add pull request feedback
oriolpuig 2e06d04
feat(components/molecule/tabs): pull request feedback
oriolpuig 515f559
chore(Root): Update coverage badges
sui-bot df00e82
release(components/molecule/tabs): v2.37.0 [skip ci]
sui-bot 3a45556
chore(Root): wip
andresin87 2ca5f35
chore(Root): wip
andresin87 bd990bb
feat(components/atom/input): refactor general
andresin87 0e1c0d5
feat(components/atom/input): minor input style mods
andresin87 495a98c
feat(components/atom/input): mod styles
andresin87 beab4e9
feat(components/atom/tag): add 2 sizes and fix styles
andresin87 0251f1d
fix(components/atom/input): input mask fully hooked
andresin87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,12 @@ | ||
import cx from 'classnames' | ||
|
||
import {BASE} from '../../../config.js' | ||
import {BASE, BASE_CLASS_ITEM} from '../../../config.js' | ||
|
||
export const BASE_CLASS_ADDON = `${BASE}--withAddon` | ||
export const BASE_CLASS_ADDON_WRAPPER = `${BASE_CLASS_ADDON}Wrapper` | ||
export const ADDON_TYPES = { | ||
LEFT: 'left', | ||
RIGHT: 'right' | ||
} | ||
|
||
export const getClassName = ({type}) => | ||
cx(BASE_CLASS_ADDON, `${BASE_CLASS_ADDON}--${type}`) | ||
cx(BASE_CLASS_ITEM, BASE_CLASS_ADDON, `${BASE_CLASS_ADDON}--${type}`) |
65 changes: 36 additions & 29 deletions
65
components/atom/input/src/Input/Wrappers/Addons/index.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,41 @@ | ||
#{$base-class}--withAddon { | ||
align-items: center; | ||
background-color: $bgc-atom-input-addon; | ||
border-color: $bdc-atom-input-addon; | ||
border-style: solid; | ||
color: $c-atom-input-addon; | ||
display: flex; | ||
flex-direction: column; | ||
height: inherit; | ||
justify-content: center; | ||
line-height: inherit; | ||
padding-left: $p-atom-input-addon-left; | ||
padding-right: $p-atom-input-addon-right; | ||
$base-class-addon: '#{$base-class}--withAddon'; | ||
|
||
&--right { | ||
border-width: $bdw-atom-input-addon-right; | ||
} | ||
#{$base-class} { | ||
#{$base-class-addon} { | ||
align-items: center; | ||
background-color: $bgc-atom-input-addon; | ||
border-color: $bdc-atom-input-addon; | ||
border-style: solid; | ||
color: $c-atom-input-addon; | ||
display: flex; | ||
flex-direction: column; | ||
justify-content: center; | ||
line-height: inherit; | ||
padding-left: $p-atom-input-addon-left; | ||
padding-right: $p-atom-input-addon-right; | ||
width: auto; | ||
|
||
&--left { | ||
border-width: $bdw-atom-input-addon-left; | ||
} | ||
&#{$base-class-addon}--right { | ||
border-left-width: $bdw-s; | ||
} | ||
|
||
&Wrapper { | ||
display: flex; | ||
@include atom-input-shape-wrapper( | ||
$base-class, | ||
#{'.sui-AtomInput--withAddonWrapper'}, | ||
$bdrs-atom-input-shapes, | ||
$sizes-atom-input, | ||
$bdrs-atom-input, | ||
$h-atom-input--m | ||
); | ||
&#{$base-class-addon}--left { | ||
border-right-width: $bdw-s; | ||
} | ||
} | ||
@each $state, $color in $states-atom-input { | ||
&#{$base-class}--status-#{$state} { | ||
#{$base-class}-item { | ||
&#{$base-class-addon} { | ||
border-color: $bdc-atom-input-addon; | ||
&#{$base-class-addon}--right { | ||
border-left-color: $color; | ||
} | ||
&#{$base-class-addon}--left { | ||
border-right-color: $color; | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
13 changes: 8 additions & 5 deletions
13
components/atom/input/src/Input/Wrappers/Button/InputButton.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import {BASE} from '../../../config.js' | ||
import {BASE, BASE_CLASS_ITEM} from '../../../config.js' | ||
|
||
export {BASE_CLASS_ITEM} | ||
export const BASE_CLASS_BUTTON = `${BASE}--withButton` |
14 changes: 2 additions & 12 deletions
14
components/atom/input/src/Input/Wrappers/Button/index.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,3 @@ | ||
#{$base-class}--withButton { | ||
display: flex; | ||
width: 100%; | ||
|
||
&-input { | ||
flex: 1; | ||
width: 100%; | ||
} | ||
|
||
&-button { | ||
margin-left: $m-m; | ||
} | ||
#{$base-class}--withButton-button { | ||
overflow: hidden; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giodelabarrera
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update a la react-imask: 6 con imask 6