New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include smaller tablets #266

Open

SUPERCILEX opened this issue Sep 11, 2019 · 0 comments

Labels

bug feature:home

Owner

SUPERCILEX commented Sep 11, 2019 •

edited

Loading

Should be:

(resources.getConfiguration().screenLayout & Configuration.SCREENLAYOUT_SIZE_MASK) > Configuration.SCREENLAYOUT_SIZE_LARGE ||
  (configuration.screenLayout & Configuration.SCREENLAYOUT_SIZE_MASK) <= Configuration.SCREENLAYOUT_SIZE_LARGE && configuration.smallestScreenWidthDp >= 600;

But is:

Robot-Scouter/library/core-ui/src/main/java/com/supercilex/robotscouter/core/ui/Ui.kt

Lines 28 to 30 in c845795

    
           val size: Int = configuration.screenLayout and Configuration.SCREENLAYOUT_SIZE_MASK 
        
           return size == Configuration.SCREENLAYOUT_SIZE_LARGE && configuration.landscape || 
        
                   size > Configuration.SCREENLAYOUT_SIZE_LARGE

SUPERCILEX added bug feature:home labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment