Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensionality error in DREAM algorithm? #255

Open
pseur opened this issue Jan 31, 2025 · 0 comments
Open

Dimensionality error in DREAM algorithm? #255

pseur opened this issue Jan 31, 2025 · 0 comments
Labels

Comments

@pseur
Copy link

pseur commented Jan 31, 2025

Thank you very much for developing this package. I would like to use the DREAM sampler to calibrate uncertain parameters (i.e., sample a posterior distribution) using new experimental data I collected. There, to update the state after the first sampling, I see that you are sampling a random number "norm_vars", which has shape "(self.n_chain, self.n_chain)".

Image

To me however, it should be of dimension "(self.n_chains,current_state.shape[1])", as current_state.shape[1] is equal to the number of uncertain parameters to calibrate (i.e., the state).

Image

Otherwise, it cannot be added to the entries of the state in the following line:

Image

I hope it makes sense,
Thank you in advance!

@pseur pseur added the bug label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant