Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/cache cmake list #33

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Chore/cache cmake list #33

wants to merge 5 commits into from

Conversation

jeswr
Copy link
Collaborator

@jeswr jeswr commented Feb 12, 2023

Caches the CmakeList.txt file to take 4-5min off build times.

Not sure if it is actually good practice or not to be caching this though (@JanWielemaker ?)

@jeswr jeswr changed the title Chore/cache cmake lit Chore/cache cmake list Feb 12, 2023
@JanWielemaker
Copy link
Member

I'm not familiar with the GitHub Docker workflows, for example I do not know whether/how long Docker intermediate layers are preserved. If they are, you can implements various tricks such as using an incremental build. Anyway, caching the configuration is probably fine as long as you can flush the cache when upgrading emsdk.

@jeswr jeswr marked this pull request as draft May 5, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants