Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing a local pack fails if git is not installed #1305

Open
matko opened this issue Aug 21, 2024 · 0 comments
Open

installing a local pack fails if git is not installed #1305

matko opened this issue Aug 21, 2024 · 0 comments

Comments

@matko
Copy link
Contributor

matko commented Aug 21, 2024

Starting in 9.1.22, it has become necessary to have git installed to install a pack, even if the pack to be installed is already present locally.

I suspect this is due to

; is_git_directory(Source)
.

It looks like link(true) would be a good way to not reach that branch, but unfortunately, that leads to errors down the line when a status.db is attempted to be written in the source directory, which might not be writable.

Maybe this could check for an explicit git(false) in the options before attempting to call git.

Initially reported here: NixOS/nixpkgs#336326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant