Update particle splitting script for particles with >64 splits #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolbox/swiftsim/particle_splitting/generate_splitting_information.py
Outdated
Show resolved
Hide resolved
toolbox/swiftsim/particle_splitting/generate_splitting_information.py
Outdated
Show resolved
Hide resolved
|
Ready for review, I've tested this on the EAGLE_6 example, and everything seems to be working as expected. |
|
Is this ready to be reviewed? |
|
Yep, I tested it on the EAGLE box by setting the size of SplitTree to 8 to cause overflows |
toolbox/swiftsim/particle_splitting/generate_splitting_information.py
Outdated
Show resolved
Hide resolved
|
Maybe we should update the pipeline sbatch scripts to pass the particle splitting directory |
toolbox/swiftsim/particle_splitting/generate_splitting_information.py
Outdated
Show resolved
Hide resolved
toolbox/swiftsim/particle_splitting/generate_splitting_information.py
Outdated
Show resolved
Hide resolved
|
Yes, we should update the pipeline scripts so that it defaults to loading the overflow split information. Safer that omitting it. |
toolbox/swiftsim/pipeline/submission_scripts/submit_particle_splits.sh
Outdated
Show resolved
Hide resolved
VictorForouhar
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating which particles have split from other we make use of the
SplitTreesdataset output by SWIFT. For Colibre the datatype is a long, so it can hold at most information about 64 particles splits. We were finding some particles that had more than 64 splits, and so couldn't reproduce the full split trees.In https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/2000 we are now logging information about particles that exceed this limit to a text file. This PR updates HBT to read in this new SWIFT output.
TODO: