Refine binding energy of 10% of total particles #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can run tests using 1% and 10% of the particles, and see if that makes a difference. Submitting now... |
|
Note that once we implement halo unbinding in multiple MPI ranks, this step will use more memory than the actual iterative unbinding itself. |
…centre To recover a constant value of subsampling, one can use a value of 0.
|
Based on my tests, 1% of particles can be insufficient when trying to improve the centering. I suggest we go with a default of 10%. Do we want to keep the new parameter I added as an option for a user to use? |
|
I think it's good to have it as a parameter, makes it more likely that people will be aware that the refinement step exists. |
VictorForouhar
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Everything looks good to me. @robjmcgibbon any further comments before merging, especially concerning my changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at https://leiden-observatory.slack.com/archives/C0697E1L4MA/p1728981990119389
The 10% value is arbitrary, so I'm opening to changing it