Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .NET Core 3.0 build #7

Closed
mnadareski opened this issue Feb 19, 2020 · 1 comment
Closed

Fix .NET Core 3.0 build #7

mnadareski opened this issue Feb 19, 2020 · 1 comment
Assignees
@mnadareski
Labels
bug Something isn't working enhancement New feature or request

Comments

@mnadareski
Copy link
Collaborator

At the moment, the .NET Core 3.0 build will fail anytime it runs across an MS cabinet file due to the library that it uses, libmspack4n, not supporting .NET Core 3.0. To address this, there are 2 options:

  • Update the base project to support .NET Core 3.0 by default (in-progress with the PR here: .NET Core and VS2019 Compatibility activescott/libmspack4n#7)
  • Pull a local version of the code into the external code folder and keep it up to date with the base project, giving full attribution. This is less preferred since it's far less automated than the former.
@mnadareski mnadareski added bug Something isn't working enhancement New feature or request labels Feb 19, 2020
@mnadareski mnadareski self-assigned this Feb 19, 2020
@mnadareski mnadareski mentioned this issue Feb 19, 2020
Closed
@mnadareski
Copy link
Collaborator Author

Fixed by 73aae81 and e3bed19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnadareski mnadareski

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnadareski