SEBSERV-652 fixed by apply proper form URL encoding to Moodle POST body

Author: anhefti

src/main/java/ch/ethz/seb/sebserver/gbl/util/Utils.java

@@ -629,16 +629,6 @@ public static String toColorFractionString(final int fraction) {
     }
 
     public static String toAppFormUrlEncodedBody(final MultiValueMap<String, String> attributes) {
-        return toAppFormUrlEncodedBodyForSPService(attributes);
-        // TODO do it all the same with toAppFormUrlEncodedBody
-//        if (attributes == null) {
-//            return StringUtils.EMPTY;
-//        }
-//
-//        return reduceFormUrlAttributes(attributes);
-    }
-
-    public static String toAppFormUrlEncodedBodyForSPService(final MultiValueMap<String, String> attributes) {
         if (attributes == null) {
             return StringUtils.EMPTY;
         }

src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/proctoring/ScreenProctoringAPIBinding.java

@@ -8,7 +8,6 @@
 
 package ch.ethz.seb.sebserver.webservice.servicelayer.session.impl.proctoring;
 
-import static ch.ethz.seb.sebserver.webservice.datalayer.batis.mapper.ScreenProctoringGroopRecordDynamicSqlSupport.sebGroupId;
 import static ch.ethz.seb.sebserver.webservice.servicelayer.session.impl.proctoring.SPS_API.*;
 
 import java.util.*;
@@ -914,7 +913,7 @@ Tuple<String> createSEBSession(
         params.add(SESSION.ATTR_CLIENT_MACHINE_NAME, clientConnection.getClientMachineName());
         params.add(SESSION.ATTR_CLIENT_OS_NAME, clientConnection.getClientOsName());
         params.add(SESSION.ATTR_CLIENT_VERSION, clientConnection.getClientVersion());
-        final String paramsFormEncoded = Utils.toAppFormUrlEncodedBodyForSPService(params);
+        final String paramsFormEncoded = Utils.toAppFormUrlEncodedBody(params);
 
         final ResponseEntity<String> exchange = apiTemplate.exchange(uri, paramsFormEncoded);
         if (exchange.getStatusCode() != HttpStatus.OK) {
@@ -1193,7 +1192,7 @@ private ScreenProctoringGroup createGroupOnSPS(
         params.add(GROUP.ATTR_NAME, name);
         params.add(GROUP.ATTR_DESCRIPTION, "Created by SEB Server");
         params.add(GROUP.ATTR_EXAM_ID, spsExamUUID);
-        final String paramsFormEncoded = Utils.toAppFormUrlEncodedBodyForSPService(params);
+        final String paramsFormEncoded = Utils.toAppFormUrlEncodedBody(params);
 
         final ResponseEntity<String> exchange = apiTemplate.exchange(uri, paramsFormEncoded);
         if (exchange.getStatusCode() != HttpStatus.OK) {
@@ -1236,7 +1235,7 @@ private void createExam(
                     uuid,
             /*settings.deletionTime */ null,
             supporterIds);
-            final String paramsFormEncoded = Utils.toAppFormUrlEncodedBodyForSPService(params);
+            final String paramsFormEncoded = Utils.toAppFormUrlEncodedBody(params);
 
             final ResponseEntity<String> exchange = apiTemplate.exchange(uri, paramsFormEncoded);
             if (exchange.getStatusCode() != HttpStatus.OK) {
@@ -1358,7 +1357,7 @@ private void createSEBAccess(
             final MultiValueMap<String, String> params = new LinkedMultiValueMap<>();
             params.add(SEB_ACCESS.ATTR_NAME, name);
             params.add(SEB_ACCESS.ATTR_DESCRIPTION, description);
-            final String paramsFormEncoded = Utils.toAppFormUrlEncodedBodyForSPService(params);
+            final String paramsFormEncoded = Utils.toAppFormUrlEncodedBody(params);
 
             final ResponseEntity<String> exchange = apiTemplate.exchange(uri, paramsFormEncoded);
             if (exchange.getStatusCode() != HttpStatus.OK) {