Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wraithstrike (suggestion) #3

Open
dolio opened this issue Aug 3, 2021 · 2 comments
Open

Wraithstrike (suggestion) #3

dolio opened this issue Aug 3, 2021 · 2 comments

Comments

@dolio
Copy link

dolio commented Aug 3, 2021

Hello,

I was looking at Wraithstrike, and noticed you're manually implementing touch attacks, because setting the touch attack flag didn't work.

The reason it didn't work is that you're setting it in the attacker-based AC hook, and that won't necessarily run before all the other AC hooks. It seems the way that touch attacks work is that armor hooks avoid adding bonuses if the flag is set.

However, I happen to know a way to make it work. The AttackPacket from the ToHit hooks gets reused for the AC hooks, and those run before AC. So if you set the touch attack flag in the ToHit hooks, it will cause it to act as a touch attack in the AC hooks.

However, I also wonder if touch AC should work your way (via explicit caps) in general. I noticed that the amulet of natural armor gets erroneously added to touch AC. So it might be better for armor caps to be set by the general callback if the touch attack flag is set.

@Sagenlicht
Copy link
Owner

Thanks dolio for pointing this out to me, I did update the spell.

I assume the amulet uses a wrong bonus type integer? I can't answer your last question about how the game should handle touch attacks in general.

@dolio
Copy link
Author

dolio commented Aug 3, 2021

Oh, that's a possibility. I didn't actually check if Wraithstrike blocks the amulet bonus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants