Climber #12
Climber #12
Conversation
There was a problem hiding this comment.
This does not look like it will work. I think we will need to wait until it can be tested before merging it. There are a lot of issues that need to be fixed. Also please update the branch before saying it is ready for a review, half the changes make no sense since it is not up to date with main.
build.gradle
Outdated
| @@ -68,7 +68,7 @@ dependencies { | |||
| simulationRelease wpi.sim.enableRelease() | |||
|
|
|||
| testImplementation 'org.junit.jupiter:junit-jupiter:5.10.1' | |||
| testRuntimeOnly 'org.junit.platform:junit-platform-launcher' | |||
simgui-ds.json
Outdated
| @@ -0,0 +1,97 @@ | |||
| { | |||
There was a problem hiding this comment.
Remove all of these changes, or see what the difference is after merging main into this branch properly.
| public static final int kFrontRightTurningEncoderPort = 18; | ||
| public static final int kRearRightTurningEncoderPort = 17; | ||
|
|
||
| public static final double kFrontLeftTurningEncoderOffset = 0; |
There was a problem hiding this comment.
These were removed in main, they should not be here.
| // configuration | ||
|
|
||
| // TODO: Tune this PID before running on a robot on the ground | ||
| public static final double kPModuleTurningController = -0.3; |
There was a problem hiding this comment.
Again, a change made in main, not updated/being redone in this branch.
| } | ||
|
|
||
| // Intake PID and Encoder Constants | ||
| public static class IntakeConstants { |
There was a problem hiding this comment.
Intake and shooter changes should not be on this branch.
| * Extends both arms | ||
| */ | ||
| public void forward() { | ||
| m_leftSolenoid.set(kOff); |
There was a problem hiding this comment.
Literally all of these methods with different names set the solenoids to kOff. This is another major bug that really should never even have been committed.
No description provided.