From eb03f73bc28750da808de2f8410b9942ecc11849 Mon Sep 17 00:00:00 2001 From: Safiya B Date: Sat, 11 Mar 2023 22:02:00 -0800 Subject: [PATCH 001/169] Fix a few locators for Q3 robot tests --- .../resources/CustomizableRollupsPageObject.py | 3 +-- .../resources/EngagementPlanTemplatesPageObject.py | 4 ++-- robot/Cumulus/resources/NPSP.py | 13 +++++-------- robot/Cumulus/resources/locators_55.py | 9 +++++---- .../asc_primary_contact_organization_gift.robot | 2 -- .../deletebehaviors_household.robot | 2 +- .../contacts_accounts/deletecontact_household.robot | 2 +- .../browser/crlps/total_current_year_payments.robot | 1 - .../create_donation_and_payment.robot | 2 +- .../browser/donations_payments/create_grant.robot | 2 +- .../create_matching_donation.robot | 2 +- .../browser/donations_payments/data_imports.robot | 2 +- .../donations_payments/lead_conversion.robot | 2 +- .../engagement_plans/create_engagement_plan.robot | 2 +- .../engagement_plans/edit_engagement_plan.robot | 2 +- robot/Cumulus/tests/browser/gaus/create_gau.robot | 2 +- .../browser/levels/create_edit_delete_level.robot | 2 +- .../manage_households/add_address_managehh.robot | 2 +- .../add_existingcontact_managehh.robot | 2 +- .../manage_households/add_newcontact_managehh.robot | 2 +- .../manage_households/change_naming_managehh.robot | 2 +- .../npsp_settings/edit_and_verify_setting.robot | 2 +- .../verify_payment_allocations_setting.robot | 2 +- .../relationships/create_relationships.robot | 2 +- .../browser/tdtm/tdtm_username_exclude.robot.robot | 2 +- .../check_recurring_auto_naming.robot | 2 +- ..._fixed_length_recurring_donation_divide_by.robot | 2 +- ...ixed_length_recurring_donation_multiply_by.robot | 2 +- ...reate_recurring_donation_and_check_rollups.robot | 2 +- .../create_recurring_donation_ui.robot | 9 +++++++-- .../zcreate_fixed_erd_record.robot | 2 +- .../zcreate_open_erd_for_contact.robot | 2 +- .../zcreate_open_erd_record.robot | 2 +- ...zedit_day_of_month_verify_next_opportunity.robot | 2 +- .../zedit_effective_date_erd_record.robot | 2 +- .../zedit_erd_day_of_month.robot | 2 +- ...t_erd_day_of_month_with_manual_opportunity.robot | 2 +- .../zedit_erd_installment_period.robot | 2 +- .../zedit_open_erd_record.robot | 2 +- 39 files changed, 52 insertions(+), 53 deletions(-) diff --git a/robot/Cumulus/resources/CustomizableRollupsPageObject.py b/robot/Cumulus/resources/CustomizableRollupsPageObject.py index 946ec85b7ae..a1a25111ec5 100644 --- a/robot/Cumulus/resources/CustomizableRollupsPageObject.py +++ b/robot/Cumulus/resources/CustomizableRollupsPageObject.py @@ -10,8 +10,7 @@ class CustomRollupSettingsPage(BaseNPSPPage, BasePage): def navigate_to_crlpsettings(self, filter_name=None): - """ Click on the Navigate CRLP Button and wait for the page to load - """ + """ Click on the Navigate CRLP Button and wait for the page to load """ locator = npsp_lex_locators["id"].format("navigateCRLPs") self.selenium.click_element(locator) self.selenium.wait_until_location_contains( diff --git a/robot/Cumulus/resources/EngagementPlanTemplatesPageObject.py b/robot/Cumulus/resources/EngagementPlanTemplatesPageObject.py index b878f74faa0..ae24f533ee2 100644 --- a/robot/Cumulus/resources/EngagementPlanTemplatesPageObject.py +++ b/robot/Cumulus/resources/EngagementPlanTemplatesPageObject.py @@ -40,8 +40,8 @@ def click_and_wait_for_task(self, taskname): def enter_task_id_and_subject(self, id, value): """Enter values into corresponding task subject fields based on last 2 digits of id""" - locator = npsp_lex_locators['engagement_plan']['input_box'].format(id) - self.selenium.wait_until_element_is_visible(locator,60) + locator = npsp_lex_locators['engagement_plan']['input_box'].format(id, "Subject") + self.selenium.wait_until_element_is_visible(locator, 60) self.salesforce.scroll_element_into_view(locator) self.selenium.get_webelement(locator).send_keys(value) diff --git a/robot/Cumulus/resources/NPSP.py b/robot/Cumulus/resources/NPSP.py index 18750981d27..53e4e7b7c91 100644 --- a/robot/Cumulus/resources/NPSP.py +++ b/robot/Cumulus/resources/NPSP.py @@ -499,12 +499,10 @@ def verify_occurence(self,title,value): def check_record_related_item(self,title,value): """Verifies that the given value is displayed under the related list identified by title on a record view page""" self.salesforce.load_related_list(title) - locator=npsp_lex_locators['record']['related']['item'].format(title,value) + locator = npsp_lex_locators['record']['related']['item'].format(title) self.selenium.wait_until_page_contains_element(locator) - actual_value=self.selenium.get_webelement(locator).text - assert value == actual_value, "Expected value to be {} but found {}".format( - value, actual_value - ) + actual_value = self.selenium.get_webelement(locator).text + assert value == actual_value, "Expected value to be {} but found {}".format(value, actual_value) def select_related_dropdown(self,title): @@ -571,7 +569,6 @@ def click_special_object_button(self, title): self.selenium.wait_until_element_is_visible(locator,error="Button "+ title +" not found on the page") self.selenium.get_webelement(locator).click() - def check_related_list_values(self,list_name,*args): """Verifies the value of custom related list""" self.salesforce.load_related_list(list_name) @@ -803,9 +800,9 @@ def get_npsp_locator(self, path, *args, **kwargs): return main_loc def wait_for_locator(self, path, *args, **kwargs): - """Waits for 60 sec for the specified locator""" + """Waits for 180 sec for the specified locator""" main_loc = self.get_npsp_locator(path,*args, **kwargs) - self.selenium.wait_until_element_is_visible(main_loc, timeout=60) + self.selenium.wait_until_element_is_visible(main_loc, timeout=180) def wait_for_locator_is_not_visible(self, path, *args, **kwargs): """Waits for 60 sec for the specified locator""" diff --git a/robot/Cumulus/resources/locators_55.py b/robot/Cumulus/resources/locators_55.py index 6563aab7041..e6ad652b6b7 100644 --- a/robot/Cumulus/resources/locators_55.py +++ b/robot/Cumulus/resources/locators_55.py @@ -42,7 +42,7 @@ 'drop-down':'//div[contains(@class, "slds-card")]/header[.//span[@title="{}"]]/parent::*/div/div/div/a[contains(@class, "slds-button")]', 'title':'//div/h2//a[./span[text()="{}"]]', 'viewall':'//article[contains(@class, "slds-card slds-card_boundary")][.//span[@title="{}"]]//a[.//span[@class="view-all-label"]]', - 'item':"//article[contains(@class, 'slds-card_boundary')][.//img][.//span[@title='{}']]//h3//a", + 'item':"//article[contains(@class, 'slds-card_boundary')][.//img][.//span[@title='{}']]//h3//a//span", 'field_value': '//a[text()="{}"]/ancestor::li//div[contains(@class, "slds-item--detail")]//*[text()="{}"]', 'link':"//article[contains(@class, 'slds-card slds-card_boundary')][.//span[@title='{}']]//table/tbody/tr[.//td//*[text()='{}']]/th//a", 'dd-link':'//a[@name="{}"]', @@ -116,7 +116,7 @@ 'related_list_items':'//article[contains(@class,"slds-card_boundary")][.//a[contains(@class, "slds-card")]/span[text() = "{}"]]//div[contains(@class, "listDisplays")]//*[text()="{}"]', 'span_button':'//span[text()="{}"]', 'modalspan_button':'//div[contains(@class,"modal-body")]//span[text()="{}"]', - 'related_drop_down':'//div/a[contains(@class,"slds-button")]/ancestor::li/div/a', + 'related_drop_down':"//li[contains(@class, 'forceRecordLayout')]//a[contains(text(), '{}')]/ancestor::h3[contains(@class, 'primaryField')]/following-sibling::div//a[@role='button']", 'span':"//span[@title='{}']", 'header_field_value':'//*[contains(@class, "slds-page-header__detail")][.//*[@title="{}"]]//*[text()="{}"]', 'header_datepicker':'//li[contains(@class, "slds-page-header__detail")][.//p[contains(@class, "slds-text-heading--label")][@title="{}"]]//*[@class="uiOutputDate"]', @@ -126,7 +126,7 @@ 'field_lookup_value': "//a[@role='option'][.//div[@title='{}']]", 'field-value':"//div[contains(@class,'slds-form-element')][./label[text()='{}']]/div/span", 'header':'//h1//child::div/span[text()="{}"]', - 'check_related_list_item':'//article[.//span[text() = "{}"]]/descendant::tbody//th/*/*/*/*/*/*/*/*/a/span[text()="{}"]', + 'check_related_list_item': '//article[.//span[text() = "{}"]]/descendant::tbody//th//a//span[text()="{}"]', 'detail_page': { 'section_header':'//h3//span[text()="{}"]', 'address':'//h3[contains(@class, "slds-section__title")][.//span[contains(text(),"Address")]]/../..//div[contains(@class, "test-id")]/span[text()= "{}"]/../following-sibling::div//a//div[contains(@class, "slds")]', @@ -134,6 +134,7 @@ 'field-value':{ 'verify_field_value1':'//div[contains(@class, "forcePageBlockItem")]/div/div//span[text()="{}"]/../../div[2]/span/span[text() = "{}"]', 'verify_field_value2':'//force-record-layout-item//div[./span[text()="{}"]]/following-sibling::div//lightning-formatted-text[text() = "{}"]', + 'verify_field_value3':'//records-record-layout-item//div[./span[text()="{}"]]/following-sibling::div//lightning-formatted-text[text() = "{}"]' }, 'edit_mode':{ 'section_header':'//div[contains(@class,"forcePageBlockSectionEdit")]/h3//span[text()="{}"]', @@ -160,7 +161,7 @@ 'field-value':'//tbody/tr[./th//a[text()="{}"]]/td[.//span[text()="{}"]]', }, 'engagement_plan':{ - 'input_box':'//fieldset[./legend[text()="{}"]]//div[@class="requiredInput"]/input', + 'input_box':'//fieldset[./legend[text()="{}"]]//input[@aria-label="{}"]', 'dropdown':'//div[contains(@class,"slds-p-top_small")]/label[text()="{}"]/following-sibling::div/select', 'checkbox':'//div[contains(@class,"slds-p-top_small")]/label[@class="slds-checkbox"][./span/following-sibling::{}[text()="{}"]/]', 'button':'//div[contains(@class,"slds-button-group")][.//span[text()="toTask {}"]]/button[contains(text(),"{}")]', diff --git a/robot/Cumulus/tests/browser/automated_soft_credits/asc_primary_contact_organization_gift.robot b/robot/Cumulus/tests/browser/automated_soft_credits/asc_primary_contact_organization_gift.robot index c491b0b3d6d..023a27ec940 100644 --- a/robot/Cumulus/tests/browser/automated_soft_credits/asc_primary_contact_organization_gift.robot +++ b/robot/Cumulus/tests/browser/automated_soft_credits/asc_primary_contact_organization_gift.robot @@ -20,9 +20,7 @@ Setup Test Data ... Name=${data}[account][Name] $50 donation Amount=50 ${ns}Primary_Contact__c=${data}[contact][Id] Set suite variable &{opportunity} - *** Variables *** - &{contact_fields} Email=test@example.com &{account_fields} Type=Organization diff --git a/robot/Cumulus/tests/browser/contacts_accounts/deletebehaviors_household.robot b/robot/Cumulus/tests/browser/contacts_accounts/deletebehaviors_household.robot index 2da162b8d02..62242df16b2 100644 --- a/robot/Cumulus/tests/browser/contacts_accounts/deletebehaviors_household.robot +++ b/robot/Cumulus/tests/browser/contacts_accounts/deletebehaviors_household.robot @@ -7,7 +7,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** Setup Test Data diff --git a/robot/Cumulus/tests/browser/contacts_accounts/deletecontact_household.robot b/robot/Cumulus/tests/browser/contacts_accounts/deletecontact_household.robot index 4449dc7cb4c..8e79f999e8e 100644 --- a/robot/Cumulus/tests/browser/contacts_accounts/deletecontact_household.robot +++ b/robot/Cumulus/tests/browser/contacts_accounts/deletecontact_household.robot @@ -7,7 +7,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** Setup Test Data diff --git a/robot/Cumulus/tests/browser/crlps/total_current_year_payments.robot b/robot/Cumulus/tests/browser/crlps/total_current_year_payments.robot index 254afdc9ca7..3674a6cc1ed 100644 --- a/robot/Cumulus/tests/browser/crlps/total_current_year_payments.robot +++ b/robot/Cumulus/tests/browser/crlps/total_current_year_payments.robot @@ -53,7 +53,6 @@ Total Current Year Payments on Prior Year Pledges [Documentation] Calculates Total Current Year Payments on Prior Year opportunity Pledges ... Enables CRLP settings, creates the custom fields on account and payment objects required for rollup ... Creates a filter and crlp setting to rollup the amount of current year payments on a previous year opportunity - [Tags] feature:CRLP unstable api quadrant:q3 # Create a Filter group and CRLP setting after checking prior records do not check if element exists diff --git a/robot/Cumulus/tests/browser/donations_payments/create_donation_and_payment.robot b/robot/Cumulus/tests/browser/donations_payments/create_donation_and_payment.robot index 693a3b3f7aa..886522e1375 100644 --- a/robot/Cumulus/tests/browser/donations_payments/create_donation_and_payment.robot +++ b/robot/Cumulus/tests/browser/donations_payments/create_donation_and_payment.robot @@ -10,7 +10,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** # Sets test data contact and an opportunity for the contact diff --git a/robot/Cumulus/tests/browser/donations_payments/create_grant.robot b/robot/Cumulus/tests/browser/donations_payments/create_grant.robot index 591236aa608..a3f45e2f6a3 100644 --- a/robot/Cumulus/tests/browser/donations_payments/create_grant.robot +++ b/robot/Cumulus/tests/browser/donations_payments/create_grant.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** # Sets test data contact and an opportunity for the contact diff --git a/robot/Cumulus/tests/browser/donations_payments/create_matching_donation.robot b/robot/Cumulus/tests/browser/donations_payments/create_matching_donation.robot index 0aefadce51a..610d57191dd 100644 --- a/robot/Cumulus/tests/browser/donations_payments/create_matching_donation.robot +++ b/robot/Cumulus/tests/browser/donations_payments/create_matching_donation.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** # Sets test data contact and an opportunity for the contact diff --git a/robot/Cumulus/tests/browser/donations_payments/data_imports.robot b/robot/Cumulus/tests/browser/donations_payments/data_imports.robot index 5f2c37fc50f..2f94021dc63 100644 --- a/robot/Cumulus/tests/browser/donations_payments/data_imports.robot +++ b/robot/Cumulus/tests/browser/donations_payments/data_imports.robot @@ -4,7 +4,7 @@ Resource robot/Cumulus/resources/NPSP.robot Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/DataImportPageObject.py Suite Setup Open Test Browser -#Suite Teardown Delete Records and Close Browser +#Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Test Cases *** diff --git a/robot/Cumulus/tests/browser/donations_payments/lead_conversion.robot b/robot/Cumulus/tests/browser/donations_payments/lead_conversion.robot index 16da866a9ca..c12d3fddd57 100644 --- a/robot/Cumulus/tests/browser/donations_payments/lead_conversion.robot +++ b/robot/Cumulus/tests/browser/donations_payments/lead_conversion.robot @@ -7,7 +7,7 @@ Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/LeadsPageObject.py Suite Setup Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Test Cases *** diff --git a/robot/Cumulus/tests/browser/engagement_plans/create_engagement_plan.robot b/robot/Cumulus/tests/browser/engagement_plans/create_engagement_plan.robot index af6ea8247c2..68b790d2643 100644 --- a/robot/Cumulus/tests/browser/engagement_plans/create_engagement_plan.robot +++ b/robot/Cumulus/tests/browser/engagement_plans/create_engagement_plan.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/NPSP.py Suite Setup Run keywords ... Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Variables *** diff --git a/robot/Cumulus/tests/browser/engagement_plans/edit_engagement_plan.robot b/robot/Cumulus/tests/browser/engagement_plans/edit_engagement_plan.robot index 85066862be2..e748df7b932 100644 --- a/robot/Cumulus/tests/browser/engagement_plans/edit_engagement_plan.robot +++ b/robot/Cumulus/tests/browser/engagement_plans/edit_engagement_plan.robot @@ -9,7 +9,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** # Setup a contact with parameters specified diff --git a/robot/Cumulus/tests/browser/gaus/create_gau.robot b/robot/Cumulus/tests/browser/gaus/create_gau.robot index bed3c8dfcf3..05c41086c63 100644 --- a/robot/Cumulus/tests/browser/gaus/create_gau.robot +++ b/robot/Cumulus/tests/browser/gaus/create_gau.robot @@ -4,7 +4,7 @@ Resource robot/Cumulus/resources/NPSP.robot Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/GAUPageObject.py Suite Setup Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Test Cases *** diff --git a/robot/Cumulus/tests/browser/levels/create_edit_delete_level.robot b/robot/Cumulus/tests/browser/levels/create_edit_delete_level.robot index 298e7c91cb3..94e6d56f537 100644 --- a/robot/Cumulus/tests/browser/levels/create_edit_delete_level.robot +++ b/robot/Cumulus/tests/browser/levels/create_edit_delete_level.robot @@ -6,7 +6,7 @@ Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/LevelsPageObject.py ... robot/Cumulus/resources/NPSPSettingsPageObject.py Suite Setup Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Variables *** diff --git a/robot/Cumulus/tests/browser/manage_households/add_address_managehh.robot b/robot/Cumulus/tests/browser/manage_households/add_address_managehh.robot index ba74b107d4a..b41d1139ffb 100644 --- a/robot/Cumulus/tests/browser/manage_households/add_address_managehh.robot +++ b/robot/Cumulus/tests/browser/manage_households/add_address_managehh.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** Setup Test Data diff --git a/robot/Cumulus/tests/browser/manage_households/add_existingcontact_managehh.robot b/robot/Cumulus/tests/browser/manage_households/add_existingcontact_managehh.robot index f3bbc05c032..0d221987638 100644 --- a/robot/Cumulus/tests/browser/manage_households/add_existingcontact_managehh.robot +++ b/robot/Cumulus/tests/browser/manage_households/add_existingcontact_managehh.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/manage_households/add_newcontact_managehh.robot b/robot/Cumulus/tests/browser/manage_households/add_newcontact_managehh.robot index 57758829192..4ca656c6113 100644 --- a/robot/Cumulus/tests/browser/manage_households/add_newcontact_managehh.robot +++ b/robot/Cumulus/tests/browser/manage_households/add_newcontact_managehh.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/manage_households/change_naming_managehh.robot b/robot/Cumulus/tests/browser/manage_households/change_naming_managehh.robot index 86d7b427615..c324b592e33 100644 --- a/robot/Cumulus/tests/browser/manage_households/change_naming_managehh.robot +++ b/robot/Cumulus/tests/browser/manage_households/change_naming_managehh.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/npsp_settings/edit_and_verify_setting.robot b/robot/Cumulus/tests/browser/npsp_settings/edit_and_verify_setting.robot index c99eda7a0f0..ca917d4ced0 100644 --- a/robot/Cumulus/tests/browser/npsp_settings/edit_and_verify_setting.robot +++ b/robot/Cumulus/tests/browser/npsp_settings/edit_and_verify_setting.robot @@ -4,7 +4,7 @@ Resource robot/Cumulus/resources/NPSP.robot Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/NPSPSettingsPageObject.py Suite Setup Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Test Cases *** diff --git a/robot/Cumulus/tests/browser/npsp_settings/verify_payment_allocations_setting.robot b/robot/Cumulus/tests/browser/npsp_settings/verify_payment_allocations_setting.robot index c00775917a6..90dfc7de581 100644 --- a/robot/Cumulus/tests/browser/npsp_settings/verify_payment_allocations_setting.robot +++ b/robot/Cumulus/tests/browser/npsp_settings/verify_payment_allocations_setting.robot @@ -4,7 +4,7 @@ Resource robot/Cumulus/resources/NPSP.robot Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/CustomSettingsPageObject.py Suite Setup Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Test Cases *** diff --git a/robot/Cumulus/tests/browser/relationships/create_relationships.robot b/robot/Cumulus/tests/browser/relationships/create_relationships.robot index 0402bdcde75..5b62395ff58 100644 --- a/robot/Cumulus/tests/browser/relationships/create_relationships.robot +++ b/robot/Cumulus/tests/browser/relationships/create_relationships.robot @@ -9,7 +9,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** diff --git a/robot/Cumulus/tests/browser/tdtm/tdtm_username_exclude.robot.robot b/robot/Cumulus/tests/browser/tdtm/tdtm_username_exclude.robot.robot index 466dea6cfdd..8b622417ae3 100644 --- a/robot/Cumulus/tests/browser/tdtm/tdtm_username_exclude.robot.robot +++ b/robot/Cumulus/tests/browser/tdtm/tdtm_username_exclude.robot.robot @@ -6,7 +6,7 @@ Library cumulusci.robotframework.PageObjects ... robot/Cumulus/resources/ContactPageObject.py ... robot/Cumulus/resources/RecurringDonationsPageObject.py Suite Setup Open Test Browser -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** API Modify Trigger Handler diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/check_recurring_auto_naming.robot b/robot/Cumulus/tests/browser/zrecurring_donations/check_recurring_auto_naming.robot index a62686a8db0..e31e0ed5d2b 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/check_recurring_auto_naming.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/check_recurring_auto_naming.robot @@ -7,7 +7,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run Keywords ... Open Test Browser ... Setup Variables -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** Setup Variables diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_divide_by.robot b/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_divide_by.robot index 8083667f6ec..29a3d190984 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_divide_by.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_divide_by.robot @@ -7,7 +7,7 @@ Suite Setup Run Keywords ... Open Test Browser ... Setup Variables ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** Setup Variables diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_multiply_by.robot b/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_multiply_by.robot index 8382d03ee33..24a6aa6dc75 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_multiply_by.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/create_a_fixed_length_recurring_donation_multiply_by.robot @@ -11,7 +11,7 @@ Suite Setup Run Keywords ... Open Test Browser ... Setup Variables ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** Setup Variables diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_and_check_rollups.robot b/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_and_check_rollups.robot index d411acd6cb3..b781e80381f 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_and_check_rollups.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_and_check_rollups.robot @@ -11,7 +11,7 @@ Suite Setup Run Keywords ... Open Test Browser ... Setup Variables ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** Setup Variables diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_ui.robot b/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_ui.robot index 20dadcdbfbb..b74814b3961 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_ui.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/create_recurring_donation_ui.robot @@ -8,7 +8,7 @@ Library cumulusci.robotframework.PageObjects Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** # Setup a contact with parameters specified @@ -41,7 +41,12 @@ Create Open Recurring Donation With Monthly Installment Reload Page Select Tab Related Current Page Should Be Details Contact - Check Related List Values Recurring Donations Robot Recurring Donation + ##### KNOWN BUG!!! ##### + # 3/10/23: The Recurring Donation name is being overwritten with the default format name + # Since NPSP does not have a future roadmap, the bug won't be fixed. + # The test here is reflecting the current behavior in the product + ${Default_RD_Name} = Set Variable ${data}[contact][FirstName] ${data}[contact][LastName] $100 - Recurring + Check Related List Values Recurring Donations ${Default_RD_Name} Load Related List Opportunities Click ViewAll Related List Opportunities Verify Payment Details 12 \ No newline at end of file diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_fixed_erd_record.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_fixed_erd_record.robot index 820626de1cf..18b09e58b75 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_fixed_erd_record.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_fixed_erd_record.robot @@ -10,7 +10,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** # Setup a contact with parameters specified diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_for_contact.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_for_contact.robot index ff8966c96c7..a77ad35eb8c 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_for_contact.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_for_contact.robot @@ -7,7 +7,7 @@ Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_record.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_record.robot index 59956a76b70..583a471175f 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_record.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zcreate_open_erd_record.robot @@ -10,7 +10,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser ***Keywords*** diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_day_of_month_verify_next_opportunity.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_day_of_month_verify_next_opportunity.robot index 252b1ba91c3..6060d847f25 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_day_of_month_verify_next_opportunity.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_day_of_month_verify_next_opportunity.robot @@ -11,7 +11,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -#Suite Teardown Delete Records and Close Browser +#Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_effective_date_erd_record.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_effective_date_erd_record.robot index 432a2fac271..d8ca0615192 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_effective_date_erd_record.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_effective_date_erd_record.robot @@ -11,7 +11,7 @@ Suite Setup Run keywords ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** Setup Test Data diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month.robot index fc24fd4518b..48e13ebe1c9 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month.robot @@ -8,7 +8,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month_with_manual_opportunity.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month_with_manual_opportunity.robot index 646c86c5f6d..12ccef7a5d5 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month_with_manual_opportunity.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_day_of_month_with_manual_opportunity.robot @@ -10,7 +10,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_installment_period.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_installment_period.robot index 92f33007f31..0e13161c1b8 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_installment_period.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_erd_installment_period.robot @@ -7,7 +7,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** diff --git a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_open_erd_record.robot b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_open_erd_record.robot index 4f059d21571..bcfe52fc8c2 100644 --- a/robot/Cumulus/tests/browser/zrecurring_donations/zedit_open_erd_record.robot +++ b/robot/Cumulus/tests/browser/zrecurring_donations/zedit_open_erd_record.robot @@ -10,7 +10,7 @@ Suite Setup Run keywords ... Enable RD2 ... Open Test Browser ... Setup Test Data -Suite Teardown Delete Records and Close Browser +Suite Teardown Capture Screenshot and Delete Records and Close Browser *** Keywords *** From 4b78f89a1738b7e307674ed278f645f8f085f406 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Tue, 14 Mar 2023 12:39:11 -0500 Subject: [PATCH 002/169] Updating yml with static release notes --- cumulusci.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/cumulusci.yml b/cumulusci.yml index 971e3ebc175..a1f94fbfcc6 100644 --- a/cumulusci.yml +++ b/cumulusci.yml @@ -221,6 +221,11 @@ tasks: options: update_future_releases: True + github_release: + options: + release_content: | + [Salesforce.org Release Notes](https://help.salesforce.com/s/articleView?id=sfdo.Release_Notes_SFDO.htm&type=5) + github_release_notes: options: trial_info: "`TBD`" @@ -769,6 +774,12 @@ tasks: - "*.cls" flows: + + release_production: + steps: + 3: + task: None + build_unlocked_test_package: steps: 0: From 44172cb266ad080e7c482cb1fa8060cb94f16d0c Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Wed, 15 Mar 2023 10:36:34 -0500 Subject: [PATCH 003/169] Update static Release Notes text and link Co-authored-by: Melissa Barber --- cumulusci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cumulusci.yml b/cumulusci.yml index a1f94fbfcc6..a921367f2e6 100644 --- a/cumulusci.yml +++ b/cumulusci.yml @@ -224,7 +224,7 @@ tasks: github_release: options: release_content: | - [Salesforce.org Release Notes](https://help.salesforce.com/s/articleView?id=sfdo.Release_Notes_SFDO.htm&type=5) + Check out the Salesforce Release Notes on [Salesforce Help & Training](https://sfdc.co/bnL4Cb). github_release_notes: options: From e3c17bd2abc9070dc391e4b4e386c621a53db899 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Wed, 15 Mar 2023 12:25:48 -0500 Subject: [PATCH 004/169] Updating minimum cci version to support static github notes --- cumulusci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cumulusci.yml b/cumulusci.yml index a1f94fbfcc6..840d7476e22 100644 --- a/cumulusci.yml +++ b/cumulusci.yml @@ -1,4 +1,4 @@ -minimum_cumulusci_version: 3.23.0 +minimum_cumulusci_version: 3.74.0 project: name: Cumulus source_format: sfdx From 4deea160ad827137006c7b68410e42f9f13bb23d Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Mon, 3 Apr 2023 16:32:42 -0500 Subject: [PATCH 005/169] W-10866049 Manage Allocations XSS fix --- force-app/main/default/pages/ALLO_ManageAllocations.page | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/force-app/main/default/pages/ALLO_ManageAllocations.page b/force-app/main/default/pages/ALLO_ManageAllocations.page index 29418d2b8e3..62eaf82dee9 100644 --- a/force-app/main/default/pages/ALLO_ManageAllocations.page +++ b/force-app/main/default/pages/ALLO_ManageAllocations.page @@ -163,8 +163,8 @@ $Lightning.use("{!namespace}" + ":RD2_EnablementApp", function() { $Lightning.createComponent("{!namespace}" + ":utilIllustration", { - title : "{!$Label.commonAdminPermissionErrorTitle}", - message : "{!$Label.commonPermissionErrorMessage}", + title : "{!JSENCODE($Label.commonAdminPermissionErrorTitle)}", + message : "{!JSENCODE($Label.commonPermissionErrorMessage)}", size: 'small', variant: 'no-access', illustrationClass: "slds-p-top_x-large slds-m-top_x-large" @@ -194,7 +194,7 @@ From 9bffdc6e8a33621d40e8fea930a6cf9c94a89b27 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Tue, 4 Apr 2023 13:13:50 -0500 Subject: [PATCH 007/169] Fix for W-11553839 Payment Wizard --- force-app/main/default/pages/PMT_PaymentWizard.page | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/force-app/main/default/pages/PMT_PaymentWizard.page b/force-app/main/default/pages/PMT_PaymentWizard.page index f96a39065cc..ce9671cfbea 100644 --- a/force-app/main/default/pages/PMT_PaymentWizard.page +++ b/force-app/main/default/pages/PMT_PaymentWizard.page @@ -31,8 +31,8 @@ $Lightning.use("{!namespace}" + ":RD2_EnablementApp", function() { $Lightning.createComponent("{!namespace}" + ":utilIllustration", { - title : "{!$Label.commonAdminPermissionErrorTitle}", - message : "{!$Label.commonPermissionErrorMessage}", + title : "{!JSENCODE($Label.commonAdminPermissionErrorTitle)}", + message : "{!JSENCODE($Label.commonPermissionErrorMessage)}", size: 'small', variant: 'no-access', illustrationClass: "slds-p-top_x-large slds-m-top_x-large" From f76e786e0af1b879a05b12a6dc768d517a179e9d Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Tue, 4 Apr 2023 15:22:52 -0500 Subject: [PATCH 008/169] Fix for W-11547533, RD Batch settings page --- force-app/main/default/pages/STG_PanelRDBatch.page | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/force-app/main/default/pages/STG_PanelRDBatch.page b/force-app/main/default/pages/STG_PanelRDBatch.page index 47349c8f4d6..fe1cb2a9cd5 100644 --- a/force-app/main/default/pages/STG_PanelRDBatch.page +++ b/force-app/main/default/pages/STG_PanelRDBatch.page @@ -9,7 +9,7 @@
- +
From b10f13e45b55320d22fa0df08d29d5f347d96dc5 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Tue, 4 Apr 2023 16:45:26 -0500 Subject: [PATCH 009/169] W-11548191 fix, Error Log table in Settings --- .../default/classes/UTIL_SoqlListView_CTRL.cls | 11 ++++++++++- .../default/components/UTIL_SoqlListView.component | 14 +++----------- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/force-app/main/default/classes/UTIL_SoqlListView_CTRL.cls b/force-app/main/default/classes/UTIL_SoqlListView_CTRL.cls index 401a1a8c705..e2a8692b232 100644 --- a/force-app/main/default/classes/UTIL_SoqlListView_CTRL.cls +++ b/force-app/main/default/classes/UTIL_SoqlListView_CTRL.cls @@ -37,7 +37,7 @@ public with sharing class UTIL_SoqlListView_CTRL { - public UTIL_iSoqlListViewConsumer pageController { + public UTIL_iSoqlListViewConsumer pageController { get; set { if (value != null) { @@ -47,6 +47,15 @@ public with sharing class UTIL_SoqlListView_CTRL { } } + public String getListViewPageInfo () { + String listViewPageInfo = System.Label.labelListViewPageInfo; + return String.format(listViewPageInfo, new List{ + setCon.getPageNumber(), + NumberOfPages, + NumberOfItems + }); + } + // the set controller allows us to do paging in our pageTable public ApexPages.StandardSetController setCon { get { diff --git a/force-app/main/default/components/UTIL_SoqlListView.component b/force-app/main/default/components/UTIL_SoqlListView.component index c419395e145..df90e13fcc4 100644 --- a/force-app/main/default/components/UTIL_SoqlListView.component +++ b/force-app/main/default/components/UTIL_SoqlListView.component @@ -51,12 +51,8 @@ {!$Label.labelListViewLast} - - - - - - + + @@ -138,11 +134,7 @@ {!$Label.labelListViewLast} - - - - - + {!$Label.labelShowMore} From 93c040b4bab9cff04755a1805b1136b42102c667 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Wed, 5 Apr 2023 11:27:11 -0500 Subject: [PATCH 010/169] Fix for W-11564391 Contact Merge --- force-app/main/default/pages/CON_ContactMerge.page | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/force-app/main/default/pages/CON_ContactMerge.page b/force-app/main/default/pages/CON_ContactMerge.page index 4cbcf8aaa53..a2f6b6c5c8e 100644 --- a/force-app/main/default/pages/CON_ContactMerge.page +++ b/force-app/main/default/pages/CON_ContactMerge.page @@ -43,7 +43,7 @@
- +
Date: Wed, 5 Apr 2023 11:36:07 -0500 Subject: [PATCH 011/169] Fix for W-11554050 and W-11553948 Levels page --- force-app/main/default/components/UTIL_InputField.component | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/force-app/main/default/components/UTIL_InputField.component b/force-app/main/default/components/UTIL_InputField.component index f94e130e71d..a5375a6baf3 100644 --- a/force-app/main/default/components/UTIL_InputField.component +++ b/force-app/main/default/components/UTIL_InputField.component @@ -45,7 +45,7 @@ var lkLink = lkSpan.querySelector("a"); lkLink.style.visibility = ""; lkLink.className = ""; - lkLink.setAttribute("aria-label", "{!$Label.UTIL_InputFormFormFieldAltLabelLookup} {!$ObjectType[sObjType].fields[field].label}"); + lkLink.setAttribute("aria-label", "{!JSENCODE($Label.UTIL_InputFormFormFieldAltLabelLookup)} {!$ObjectType[sObjType].fields[field].label}"); lkLink.innerHTML = "" + @@ -58,7 +58,7 @@ var lkLink = lkSpan.querySelector("a"); lkLink.style.visibility = ""; lkLink.className = ""; - lkLink.setAttribute("aria-label","{!$Label.UTIL_InputFormFormFieldAltLabelDate} {!$ObjectType[sObjType].fields[field].label}"); + lkLink.setAttribute("aria-label", "{!JSENCODE($Label.UTIL_InputFormFormFieldAltLabelDate)} {!$ObjectType[sObjType].fields[field].label}"); lkLink.innerHTML = "" + From 4c5522c097b8eb0e19e64a839e4f388e7c00cc64 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Wed, 5 Apr 2023 11:47:27 -0500 Subject: [PATCH 012/169] Update HtmlOutput to allow nbsp --- force-app/main/default/classes/UTIL_HtmlOutput_CTRL.cls | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/force-app/main/default/classes/UTIL_HtmlOutput_CTRL.cls b/force-app/main/default/classes/UTIL_HtmlOutput_CTRL.cls index 0c50bf096cd..e1fac8fd357 100644 --- a/force-app/main/default/classes/UTIL_HtmlOutput_CTRL.cls +++ b/force-app/main/default/classes/UTIL_HtmlOutput_CTRL.cls @@ -48,7 +48,8 @@ public with sharing class UTIL_HtmlOutput_CTRL { ' '|para|', ' '|head1|', ' '|head2|', - ' '|head3|' + ' '|head3|', + ' ' => '|nonBreakingSpace|' }; /** @description The map of allowed urls and their temporary substitution values */ From 71687e6de1dd0f57faccd39431d28e5266a56972 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Tue, 18 Apr 2023 12:29:32 -0500 Subject: [PATCH 013/169] Hiding Application Status component since it is causing confusion in Trials --- .../default/lwc/gsApplicationStatus/gsApplicationStatus.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/force-app/main/default/lwc/gsApplicationStatus/gsApplicationStatus.js b/force-app/main/default/lwc/gsApplicationStatus/gsApplicationStatus.js index 01ec5d86c0b..50226461c72 100644 --- a/force-app/main/default/lwc/gsApplicationStatus/gsApplicationStatus.js +++ b/force-app/main/default/lwc/gsApplicationStatus/gsApplicationStatus.js @@ -21,7 +21,7 @@ export default class GsApplicationStatus extends LightningElement { @track isApplicationSubmitted = false; @track isLoading = false; @track img = ""; - @track isActiveInstance = false; + @track isActiveInstance = true; applyForFreeLicensesImg = Resources + '/gsResources/Accept_Tasks_Apply_Card.png'; checkForStatusImg = Resources + '/gsResources/gift_illustration_2.svg'; @@ -55,7 +55,8 @@ export default class GsApplicationStatus extends LightningElement { this.diffInDays = this.calculateTrialRemainingDays(result); this.isApplicationSubmitted = this.checkApplicationSubmitted(result); this.img = this.isApplicationSubmitted ? this.checkForStatusImg : this.applyForFreeLicensesImg; - this.isActiveInstance = result.trialExpirationDate == null; + // Disabling this component since it is causing confusion in new Trials and orgs that were converted from Trials + // this.isActiveInstance = result.trialExpirationDate == null; this.hideSpinner(); this.learnMoreAriaLabel = `${this.labels.gsLearnMore} ${this.labels.opensInNewLink}`; this.applyForFreeLicensesAriaLabel = `${this.labels.gsApplyForFreeLicenses} ${this.labels.opensInNewLink}`; From bbedba530ae70e57cdfbe7ff5af42aa275d19817 Mon Sep 17 00:00:00 2001 From: Reede Stockton Date: Tue, 18 Apr 2023 17:36:32 -0700 Subject: [PATCH 014/169] Add permission check to runBatchDryRun / W-9463070 --- .../main/default/classes/BGE_DataImportBatchEntry_CTRL.cls | 2 ++ 1 file changed, 2 insertions(+) diff --git a/force-app/main/default/classes/BGE_DataImportBatchEntry_CTRL.cls b/force-app/main/default/classes/BGE_DataImportBatchEntry_CTRL.cls index 5d0f216f4bf..59394fcd7d0 100644 --- a/force-app/main/default/classes/BGE_DataImportBatchEntry_CTRL.cls +++ b/force-app/main/default/classes/BGE_DataImportBatchEntry_CTRL.cls @@ -343,6 +343,8 @@ public with sharing class BGE_DataImportBatchEntry_CTRL { @AuraEnabled public static String runBatchDryRun(Id batchId, Integer numberOfRowsToReturn) { try { + checkFieldPermissions(); + Data_Import_Settings__c dataImportSettings = BDI_DataImportService.loadSettings(batchId); List allRawDataImports = getAllDataImportRecordsForDryRunByBatchId(batchId); From 7b4843af4ea9cbaa0ae4ccba6f55dd66a01cafd3 Mon Sep 17 00:00:00 2001 From: Reede Stockton Date: Wed, 19 Apr 2023 11:20:42 -0700 Subject: [PATCH 015/169] Check for Admin user in BDI_ManageAdvancedMapping.getAdvancedMappingObjectData / W-11030828 --- .../main/default/classes/BDI_ManageAdvancedMappingCtrl.cls | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/force-app/main/default/classes/BDI_ManageAdvancedMappingCtrl.cls b/force-app/main/default/classes/BDI_ManageAdvancedMappingCtrl.cls index 9d1f6bb42c6..92840957a6f 100644 --- a/force-app/main/default/classes/BDI_ManageAdvancedMappingCtrl.cls +++ b/force-app/main/default/classes/BDI_ManageAdvancedMappingCtrl.cls @@ -153,6 +153,10 @@ public class BDI_ManageAdvancedMappingCtrl { */ @AuraEnabled public static AdvancedMappingObjectData getAdvancedMappingObjectData () { + if (!isAdminUser(UserInfo.getUserId())) { + throw new AuraHandledException(Label.commonInsufficientPermissions); + } + return new AdvancedMappingObjectData(getObjectMappings(), getObjectOptions()); } From 2c96c7372bc237fb4350b518d98341f25ffd595d Mon Sep 17 00:00:00 2001 From: Reede Stockton Date: Wed, 19 Apr 2023 11:53:12 -0700 Subject: [PATCH 016/169] Move AuraEnabled restricted getDataImportSettings to GE_GiftEntryController / W-9463506 --- .../main/default/classes/GE_GiftEntryController.cls | 9 +++++++++ .../main/default/classes/UTIL_CustomSettingsFacade.cls | 1 - .../lwc/utilTemplateBuilder/utilTemplateBuilder.js | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/force-app/main/default/classes/GE_GiftEntryController.cls b/force-app/main/default/classes/GE_GiftEntryController.cls index 7f522b1c74b..133a7b0a39b 100644 --- a/force-app/main/default/classes/GE_GiftEntryController.cls +++ b/force-app/main/default/classes/GE_GiftEntryController.cls @@ -1335,6 +1335,15 @@ public with sharing class GE_GiftEntryController { } } + @AuraEnabled + public static Data_Import_Settings__c getDataImportSettings() { + if (!UTIL_Describe.getObjectDescribe('DataImportBatch__c').isUpdateable()) { + throw new AuraHandledException(Label.commonInsufficientPermissions); + } + + return UTIL_CustomSettingsFacade.getDataImportSettings(); + } + private static String retrieveBatchCurrencyIsoCode (Id batchId) { String query = new UTIL_Query() .withSelectFields(new Set{UTIL_Currency.CURRENCY_ISO_CODE_FIELD}) diff --git a/force-app/main/default/classes/UTIL_CustomSettingsFacade.cls b/force-app/main/default/classes/UTIL_CustomSettingsFacade.cls index ad7d4dbff5b..ed4d99e1fc6 100644 --- a/force-app/main/default/classes/UTIL_CustomSettingsFacade.cls +++ b/force-app/main/default/classes/UTIL_CustomSettingsFacade.cls @@ -296,7 +296,6 @@ public without sharing class UTIL_CustomSettingsFacade { * settings are defined. The ID field should be checked to determine if the returned record already exists or doesn't exist * in the database. */ - @AuraEnabled public static Data_Import_Settings__c getDataImportSettings() { if(Test.isRunningTest() && dataImportSettings == null) { dataImportSettings = new Data_Import_Settings__c(); diff --git a/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js b/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js index 8adc7c7f409..f6a84d951a3 100644 --- a/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js +++ b/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js @@ -75,7 +75,7 @@ import ACCOUNT_NAME_INFO from '@salesforce/schema/Account.Name'; import commonError from '@salesforce/label/c.commonError'; import commonUnknownError from '@salesforce/label/c.commonUnknownError'; -import getDataImportSettings from '@salesforce/apex/UTIL_CustomSettingsFacade.getDataImportSettings'; +import getDataImportSettings from '@salesforce/apex/GE_GiftEntryController.getDataImportSettings'; import getGiftEntrySettings from '@salesforce/apex/GE_GiftEntryController.getGiftEntrySettings'; From 3047082eb26b677f198aba32bcfe8ac6f4ba36a0 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Wed, 19 Apr 2023 17:00:15 -0500 Subject: [PATCH 017/169] Updating Permission check for Gift Entry --- force-app/main/default/classes/GE_GiftEntryController.cls | 4 ++-- .../default/lwc/utilTemplateBuilder/utilTemplateBuilder.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/force-app/main/default/classes/GE_GiftEntryController.cls b/force-app/main/default/classes/GE_GiftEntryController.cls index 133a7b0a39b..04cb1f04beb 100644 --- a/force-app/main/default/classes/GE_GiftEntryController.cls +++ b/force-app/main/default/classes/GE_GiftEntryController.cls @@ -1337,8 +1337,8 @@ public with sharing class GE_GiftEntryController { @AuraEnabled public static Data_Import_Settings__c getDataImportSettings() { - if (!UTIL_Describe.getObjectDescribe('DataImportBatch__c').isUpdateable()) { - throw new AuraHandledException(Label.commonInsufficientPermissions); + if (!UTIL_Permissions.canRead(UTIL_Namespace.StrTokenNSPrefix('Data_Import_Settings__c'), false)) { + return null; } return UTIL_CustomSettingsFacade.getDataImportSettings(); diff --git a/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js b/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js index f6a84d951a3..8266cd41b37 100644 --- a/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js +++ b/force-app/main/default/lwc/utilTemplateBuilder/utilTemplateBuilder.js @@ -504,7 +504,7 @@ const setRecordValuesOnTemplate = (templateSections, fieldMappings, record) => { const getPageAccess = async () => { const dataImportSettings = await getDataImportSettings(); const giftEntryGateSettings = await getGiftEntrySettings(); - const isAdvancedMappingOn = + const isAdvancedMappingOn = dataImportSettings && dataImportSettings[FIELD_MAPPING_METHOD_FIELD_INFO.fieldApiName] === ADVANCED_MAPPING; const isGiftEntryEnabled = giftEntryGateSettings[GIFT_ENTRY_FEATURE_GATE_INFO.fieldApiName]; return isAdvancedMappingOn && isGiftEntryEnabled; From 38e727a70a9f7405b8479ef83d797304f7d27132 Mon Sep 17 00:00:00 2001 From: Luke Parrott Date: Mon, 26 Jun 2023 09:39:13 -0500 Subject: [PATCH 018/169] Updating Elevate Validation to ignore newly added Payments --- .../default/classes/PMT_ValidationService.cls | 6 +++- .../classes/PMT_ValidationService_TEST.cls | 35 +++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/force-app/main/default/classes/PMT_ValidationService.cls b/force-app/main/default/classes/PMT_ValidationService.cls index be2451eb79f..a68b4239273 100644 --- a/force-app/main/default/classes/PMT_ValidationService.cls +++ b/force-app/main/default/classes/PMT_ValidationService.cls @@ -187,7 +187,11 @@ public inherited sharing class PMT_ValidationService { } private void validateElevatePayments(npe01__OppPayment__c payment, npe01__OppPayment__c oldPayment) { - if (String.isBlank(payment.Elevate_Payment_ID__c) || !config.isIntegrationEnabled() || config.hasIntegrationPermissions()) { + if (String.isBlank(payment.Elevate_Payment_ID__c) + || String.isBlank(oldPayment.Elevate_Payment_ID__c) + || !config.isIntegrationEnabled() + || config.hasIntegrationPermissions() + ) { return; } diff --git a/force-app/main/default/classes/PMT_ValidationService_TEST.cls b/force-app/main/default/classes/PMT_ValidationService_TEST.cls index 238ed7ab995..88e4f22f718 100644 --- a/force-app/main/default/classes/PMT_ValidationService_TEST.cls +++ b/force-app/main/default/classes/PMT_ValidationService_TEST.cls @@ -431,6 +431,41 @@ public with sharing class PMT_ValidationService_TEST { 'Cannot update Elevate payment without integrationPermission'); } + @IsTest + private static void verifyAddingPaymentToElevateWillNotRunValidation() { + npe01__OppPayment__c originalPayment = new npe01__OppPayment__c( + Id = UTIL_UnitTestData_TEST.mockId(npe01__OppPayment__c.SObjectType), + npe01__Payment_Amount__c = 10, + npe01__Paid__c = true + ); + + npe01__OppPayment__c updatedPayment = originalPayment.clone(true); + updatedPayment.Elevate_Payment_ID__c = 'Random'; + + PMT_ValidationService validationService = new PMT_ValidationService( + new List{updatedPayment}, + new List{originalPayment}, + TDTM_Runnable.Action.BeforeUpdate + ); + + validationService.isEnforceAccountingDataConsistency = false; + PS_IntegrationServiceConfig_TEST.Stub configStub = new PS_IntegrationServiceConfig_TEST.Stub() + .withIsIntegrationEnabled(true) + .withHasIntegrationPermissions(false); + + PMT_ValidationService.config = (PS_IntegrationServiceConfig) Test.createStub( + PS_IntegrationServiceConfig.class, + configStub + ); + + Test.startTest(); + List errorRecords = validationService.validate().getErrors(); + Test.stopTest(); + + System.assertEquals(0, errorRecords.size(), + 'Expecting Elevate validation should not run against newly added Elevate payment.'); + } + @IsTest private static void verifyElevateRefundWillNotBeValidate() { npe01__OppPayment__c originalPayment = new npe01__OppPayment__c( From 084a16b8427eb333d61abb1a87b0cb9b7b6bcec7 Mon Sep 17 00:00:00 2001 From: Dmitry Kudryashov Date: Mon, 7 Aug 2023 13:21:44 -0700 Subject: [PATCH 019/169] Updating solutation for French --- .../Salutation-fr.standardValueSetTranslation | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unpackaged/config/trial_translations/standardValueSetTranslations/Salutation-fr.standardValueSetTranslation b/unpackaged/config/trial_translations/standardValueSetTranslations/Salutation-fr.standardValueSetTranslation index 524cc54edb0..843e48661fa 100644 --- a/unpackaged/config/trial_translations/standardValueSetTranslations/Salutation-fr.standardValueSetTranslation +++ b/unpackaged/config/trial_translations/standardValueSetTranslations/Salutation-fr.standardValueSetTranslation @@ -6,7 +6,7 @@ Ms. - Mlle + Mme Mrs. From 8630c9e694636c367477052b9bf07fd683099e52 Mon Sep 17 00:00:00 2001 From: Reede Stockton Date: Thu, 7 Sep 2023 15:07:31 -0700 Subject: [PATCH 020/169] a11y WCAG 2.1 color contrast updates --- .../npsp-slds/npsp-common.css | 1 + .../components/UTIL_InputField.component | 2 + .../default/pages/ALLO_ManageAllocations.page | 2 +- .../main/default/pages/ALLO_RollupBTN.page | 2 +- .../main/default/pages/BDI_BatchOverride.page | 2 +- .../main/default/pages/BDI_DataImport.page | 2 +- .../pages/CONV_Account_Conversion.page | 4 +- .../main/default/pages/CON_ContactMerge.page | 2 +- .../default/pages/CRLP_RollupAccount_BTN.page | 2 +- .../default/pages/CRLP_RollupContact_BTN.page | 2 +- .../main/default/pages/CRLP_RollupRD_BTN.page | 2 +- .../main/default/pages/CRLP_RollupSetup.page | 2 +- .../default/pages/EP_ManageEPTemplate.page | 2 +- .../default/pages/HH_CampaignDedupeBTN.page | 2 +- force-app/main/default/pages/HH_ManageHH.page | 3 + .../default/pages/LD_LeadConvertOverride.page | 2 +- .../main/default/pages/LVL_LevelEdit.page | 2 +- .../main/default/pages/MTCH_FindGifts.page | 13 ++- .../pages/OPP_SendAcknowledgmentBTN.page | 2 +- .../main/default/pages/PMT_PaymentWizard.page | 2 +- .../default/pages/PSC_ManageSoftCredits.page | 7 +- .../default/pages/RD_AddDonationsBTN.page | 2 +- .../pages/REL_RelationshipsViewer.page | 2 +- .../pages/STG_PanelAddrVerification.page | 89 ++++++++++++------- .../default/pages/STG_PanelAffiliations.page | 7 +- .../default/pages/STG_PanelAllocations.page | 15 ++-- .../default/pages/STG_PanelContactRoles.page | 24 +++-- .../pages/STG_PanelCustomizableRollup.page | 4 +- .../main/default/pages/STG_PanelERR.page | 21 +++-- .../default/pages/STG_PanelHealthCheck.page | 11 ++- .../default/pages/STG_PanelHouseholds.page | 7 +- .../main/default/pages/STG_PanelLeads.page | 7 +- .../pages/STG_PanelOppCampaignMembers.page | 7 +- .../default/pages/STG_PanelOppRollups.page | 7 +- force-app/main/default/pages/STG_PanelRD.page | 31 ++++--- .../default/pages/STG_PanelRD2Enablement.page | 2 +- .../main/default/pages/STG_PanelRel.page | 26 +++--- .../main/default/pages/STG_PanelSchedule.page | 14 ++- .../main/default/pages/STG_PanelTDTM.page | 2 +- .../default/pages/STG_SettingsManager.page | 9 +- .../npsp-slds/npsp-common.css | 1 + 41 files changed, 220 insertions(+), 128 deletions(-) diff --git a/StaticResourceSources/npsp-slds/npsp-common.css b/StaticResourceSources/npsp-slds/npsp-common.css index 7d781f4f9ec..34e695ff644 100644 --- a/StaticResourceSources/npsp-slds/npsp-common.css +++ b/StaticResourceSources/npsp-slds/npsp-common.css @@ -17,6 +17,7 @@ input.lookupInput { input.lookupInputSLDS { width: 100%; margin-right: -30px !important; + border-color: #747474 !important; } body .dateInput input[type="text"], .slds-vf-scope .dateInput input[type="text"] { margin-left: 0; diff --git a/force-app/main/default/components/UTIL_InputField.component b/force-app/main/default/components/UTIL_InputField.component index a5375a6baf3..77d3d00fd2d 100644 --- a/force-app/main/default/components/UTIL_InputField.component +++ b/force-app/main/default/components/UTIL_InputField.component @@ -16,6 +16,7 @@ +
+
-
+
diff --git a/force-app/main/default/pages/CONV_Account_Conversion.page b/force-app/main/default/pages/CONV_Account_Conversion.page index 5909936759d..5b4798224bb 100644 --- a/force-app/main/default/pages/CONV_Account_Conversion.page +++ b/force-app/main/default/pages/CONV_Account_Conversion.page @@ -13,7 +13,7 @@ -
+
@@ -209,7 +209,7 @@
-
+