Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make method and url positionals in request to prevent crash. #22

Closed
wants to merge 1 commit into from
Closed

Conversation

dfrtz
Copy link

@dfrtz dfrtz commented Feb 7, 2022

Critical Changes

Changes

Issues Closed

@salesforce-cla
Copy link

salesforce-cla bot commented Feb 7, 2022

Thanks for the contribution! Unfortunately we can't verify the commit author(s): David Fritz <d***@p***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@dfrtz
Copy link
Author

dfrtz commented Feb 7, 2022

Blast, I didn't catch the open PR for this in #21 because I was originally submitting this to the salesforce_streamer_client repo until I realized it needed to be submitted here instead. I checked the open PRs/issues over there, but forgot to over here before submitting it. My apologies for the duplicate, I hope to see the other committed soon.

@dfrtz dfrtz closed this Feb 7, 2022
@dfrtz dfrtz deleted the positionalfix branch February 7, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant