From 7f3d60dc46a7c862c9c643ed3464e24af032c285 Mon Sep 17 00:00:00 2001
From: SaltyEgg <hzhou.me@saltyee.com>
Date: Thu, 22 Feb 2024 22:32:42 -0800
Subject: [PATCH 1/2] cleanup

---
 .../saltynote/service/ServiceApplication.kt   |  9 ++--
 .../com/saltynote/service/utils/BaseUtils.kt  | 41 ++++++++-----------
 2 files changed, 20 insertions(+), 30 deletions(-)

diff --git a/src/main/kotlin/com/saltynote/service/ServiceApplication.kt b/src/main/kotlin/com/saltynote/service/ServiceApplication.kt
index e7b9971..2e1988d 100644
--- a/src/main/kotlin/com/saltynote/service/ServiceApplication.kt
+++ b/src/main/kotlin/com/saltynote/service/ServiceApplication.kt
@@ -22,11 +22,8 @@ class ServiceApplication {
                 .build()
         )
     }
+}
 
-    companion object {
-        @JvmStatic
-        fun main(args: Array<String>) {
-            SpringApplication.run(ServiceApplication::class.java, *args)
-        }
-    }
+fun main(args: Array<String>) {
+    SpringApplication.run(ServiceApplication::class.java, *args)
 }
diff --git a/src/main/kotlin/com/saltynote/service/utils/BaseUtils.kt b/src/main/kotlin/com/saltynote/service/utils/BaseUtils.kt
index cc1c742..5b7c994 100644
--- a/src/main/kotlin/com/saltynote/service/utils/BaseUtils.kt
+++ b/src/main/kotlin/com/saltynote/service/utils/BaseUtils.kt
@@ -1,37 +1,30 @@
 package com.saltynote.service.utils
 
-import com.saltynote.service.exception.IllegalInitialException
 import org.apache.commons.lang3.StringUtils
 
-class BaseUtils private constructor() {
-    init {
-        throw IllegalInitialException("Do not instantiate me.")
-    }
-
-    companion object {
-        private var baseUrl = "https://saltynote.com"
+object BaseUtils {
+    private var baseUrl = "https://saltynote.com"
 
-        // This is used for test or dev usage, do not call it in prod.
-        fun setBaseUrl(baseUrl: String) {
-            if (StringUtils.startsWithIgnoreCase(baseUrl, "http")) {
-                Companion.baseUrl = baseUrl
-            }
+    // This is used for test or dev usage, do not call it in prod.
+    fun setBaseUrl(baseUrl: String) {
+        if (StringUtils.startsWithIgnoreCase(baseUrl, "http")) {
+            BaseUtils.baseUrl = baseUrl
         }
+    }
 
-        fun getPasswordResetUrl(secret: String): String {
-            return "$baseUrl/password/reset?token=$secret"
-        }
+    fun getPasswordResetUrl(secret: String): String {
+        return "$baseUrl/password/reset?token=$secret"
+    }
 
-        fun containsAllIgnoreCase(src: String, queries: Iterable<String>): Boolean {
-            if (StringUtils.isBlank(src)) {
+    fun containsAllIgnoreCase(src: String, queries: Iterable<String>): Boolean {
+        if (StringUtils.isBlank(src)) {
+            return false
+        }
+        for (q in queries) {
+            if (StringUtils.isNotBlank(q) && !StringUtils.containsIgnoreCase(src, q.trim { it <= ' ' })) {
                 return false
             }
-            for (q in queries) {
-                if (StringUtils.isNotBlank(q) && !StringUtils.containsIgnoreCase(src, q.trim { it <= ' ' })) {
-                    return false
-                }
-            }
-            return true
         }
+        return true
     }
 }

From 6b7df3462ef04a00e17ab2451b939466d2591cef Mon Sep 17 00:00:00 2001
From: SaltyEgg <hzhou.me@saltyee.com>
Date: Thu, 22 Feb 2024 22:39:03 -0800
Subject: [PATCH 2/2] cleanup test

---
 .../com/saltynote/service/utils/BaseUtilsTest.kt | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/src/test/kotlin/com/saltynote/service/utils/BaseUtilsTest.kt b/src/test/kotlin/com/saltynote/service/utils/BaseUtilsTest.kt
index 2ae6cfa..3cf08e1 100644
--- a/src/test/kotlin/com/saltynote/service/utils/BaseUtilsTest.kt
+++ b/src/test/kotlin/com/saltynote/service/utils/BaseUtilsTest.kt
@@ -1,26 +1,10 @@
 package com.saltynote.service.utils
 
-import com.saltynote.service.exception.IllegalInitialException
-import com.saltynote.service.utils.BaseUtils
 import org.assertj.core.api.Assertions.assertThat
-import org.junit.jupiter.api.Assertions.assertThrows
 import org.junit.jupiter.api.Assertions.assertTrue
 import org.junit.jupiter.api.Test
-import java.lang.reflect.InvocationTargetException
 
 internal class BaseUtilsTest {
-    @Test
-    fun exceptionWhenInit() {
-        val exception: Exception = assertThrows(InvocationTargetException::class.java) {
-            val pcc = BaseUtils::class.java.getDeclaredConstructor()
-            pcc.setAccessible(true)
-            val baseUtils = pcc.newInstance()
-            println(baseUtils.toString())
-        }
-        assertTrue(exception.cause is IllegalInitialException)
-        assertThat(exception.cause!!.message).isEqualTo("Do not instantiate me.")
-    }
-
     @Test
     fun testSetBaseUrl() {
         BaseUtils.setBaseUrl("http://baseUrl")