Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oversight/bug] Hand Mirror mimic properties not fully implimented #70

Open
6 tasks
Shibva opened this issue Jul 13, 2024 · 1 comment
Open
6 tasks
Labels
bug Something isn't working enhancement New feature or request

Comments

@Shibva
Copy link
Contributor

Shibva commented Jul 13, 2024

This post is a follow-up to a conversation between Shibva_ and @SamsTheNerd regarding some missing/broken properties not yet implemented or broken respectfully.

From my understanding, the hand mirror is supposed to act like a "Shadow Item" (or an item that has multiple bugged copies of itself that are all interconnected as one) and I also understand that it's not going to be a perfect replica of such and for the sake of such will keep in mind not everything listed here may be fixed or implemented.

Missing/Broken properties:

  • Mixins are broken or missing regarding their ability to copy damage statistics/properties of sed item

    • However, its properties for mining are implemented
      • Given Minecraft's attribute system, I question if it's possible to copy those from the item it's reflecting
    • Note: Damage added by enchantments work (I.e: Sharpness V reflected gives the mirror that damage boost onto the mirror while NOT giving it the actual items full damage
      • Example:
        image
  • Items are allowed to be activated if they have right-click functionality but lack the ability for them to be "Charged" (ie items that use a windup mechanic via holing the USE key (r-click) such as bows and crossbow loading)

    • Interestingly enough, crossbows cannot be charged and tetra warforge "windups" don't work yet tetra weapons with the ability to JAB (short blade offhand ability) and a crossbow that is loaded are capable of being used due to it being able to "activate" from a right click
  • being able to use a reflection of a staff (due to how hex works)

    • if there is a caster ring equipped, it will allow for the grid to stay open but will use the reduced grid
  • Phial Reflections (work as intended as far as I know, but I feel that using the handmirror would allow you to access media from it if it's in your inventory or at least hotbar [this is based on the behavior of it using media from it as long as you are holding the mirror]

  • Durability reflection: idk, support somehow for Durrability Tooltip to have its durability show on the reflected item if it has durability [current behavior: no durability indication while looking at the mirror in inventory (the durability bar also does not appear in the reflection UI element, but does show when it's in the Hotbar)
    image

  • item swap mixin or thing is broken/missing

That is all what I have; will update this if more come along with leaving a comment if something changes lel

@SamsTheNerd SamsTheNerd added bug Something isn't working enhancement New feature or request labels Jul 19, 2024
@Shibva
Copy link
Contributor Author

Shibva commented Jul 23, 2024

New Bug:

  • It appears when deployers use bound mirrors, it wont update them on the (use) of the deployer; resulting in an item being used when the item in question is not there anymore

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants