Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming dim reflections to purifications #75

Open
Shibva opened this issue Aug 7, 2024 · 1 comment
Open

Renaming dim reflections to purifications #75

Shibva opened this issue Aug 7, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@Shibva
Copy link
Contributor

Shibva commented Aug 7, 2024

The spells, Terra Reflection and Everflame Reflection are incorrectly documented in the book; the spells require an entity to be poped for it to push a bool regarding the respective check made by each; therefore:

- The description for both needs to be changed slightly
- "Returns whether or not the entity given is in the Overworld/Nether"

  • "Reflection" should be changed to Purification

Suggestion: "Nullscape Purification", the equivalence of Terra and Everflame but for the end

  • if other dimensions exist it can at least be checked if the caster using it is not in the three coregame dims
@Shibva
Copy link
Contributor Author

Shibva commented Aug 7, 2024

EDIT: looks like most of the things in the book were corrected, all that needed to be done was changing how the spell name was

fixed in 2b78689

@Shibva Shibva changed the title Terra and Everflame book entry wrong & suggesting a Nullscape Purification suggesting a Nullscape Purification for The End Aug 7, 2024
@SamsTheNerd SamsTheNerd added the documentation Improvements or additions to documentation label Oct 8, 2024
@SamsTheNerd SamsTheNerd changed the title suggesting a Nullscape Purification for The End Renaming dim reflections to purifications Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants