Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ML model usage and ml_providers list #587

Merged
merged 141 commits into from
Aug 21, 2024
Merged

Custom ML model usage and ml_providers list #587

merged 141 commits into from
Aug 21, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 21, 2024

Description

Please include a summary of the change and which is fixed.

  • Add --ml_config and --ml_model arguments to use custom models
  • replace azure and cuda arguments to --ml_providers
  • remove optional for some arguments

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.14634% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.34%. Comparing base (16dd8ac) to head (bd908b1).
Report is 1 commits behind head on main.

Files Patch % Lines
credsweeper/filters/value_entropy_base32_check.py 50.00% 3 Missing and 1 partial ⚠️
...redsweeper/filters/value_not_part_encoded_check.py 77.77% 3 Missing and 1 partial ⚠️
credsweeper/filters/value_token_base32_check.py 50.00% 3 Missing and 1 partial ⚠️
credsweeper/credentials/candidate.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files         131      131           
  Lines        4701     4715   +14     
  Branches      761      763    +2     
=======================================
+ Hits         4247     4260   +13     
- Misses        301      302    +1     
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek changed the title Ml Custom ML models usage arguments Aug 20, 2024
@babenek babenek changed the title Custom ML models usage arguments Custom ML model usage and ml_providers list Aug 20, 2024
@babenek babenek marked this pull request as ready for review August 20, 2024 19:34
@babenek babenek requested a review from a team as a code owner August 20, 2024 19:34
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 548e2cc into Samsung:main Aug 21, 2024
27 checks passed
@babenek babenek deleted the ml branch August 21, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants