Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line password patterns #601

Closed
wants to merge 58 commits into from
Closed

Command line password patterns #601

wants to merge 58 commits into from

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 28, 2024

Description

Please include a summary of the change and which is fixed.

  • Add password pattern without separator
  • Add ConvertTo-SecureString pattern

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek closed this Aug 30, 2024
@babenek babenek reopened this Sep 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.18605% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (45e0643) to head (d531c58).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
credsweeper/ml_model/features/has_html_tag.py 77.77% 2 Missing and 2 partials ⚠️
credsweeper/ml_model/features/feature.py 86.95% 2 Missing and 1 partial ⚠️
credsweeper/ml_model/features/word_in.py 92.50% 2 Missing and 1 partial ⚠️
credsweeper/ml_model/features/word_in_path.py 80.00% 2 Missing and 1 partial ⚠️
credsweeper/ml_model/features/file_extension.py 91.66% 1 Missing ⚠️
credsweeper/ml_model/features/rule_name.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   90.63%   90.75%   +0.11%     
==========================================
  Files         129      144      +15     
  Lines        4751     4887     +136     
  Branches      776      787      +11     
==========================================
+ Hits         4306     4435     +129     
- Misses        288      294       +6     
- Partials      157      158       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek
Copy link
Contributor Author

babenek commented Sep 3, 2024

20240902_152206

@babenek babenek closed this Sep 3, 2024
@babenek babenek deleted the cmdpass branch September 3, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants