Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] fix DC score for Sep Release #13874

Open
chunseoklee opened this issue Sep 2, 2024 · 2 comments
Open

[onert-micro] fix DC score for Sep Release #13874

chunseoklee opened this issue Sep 2, 2024 · 2 comments

Comments

@chunseoklee
Copy link
Contributor

chunseoklee commented Sep 2, 2024

DC(duplicated code) Score for onert-micro is 3.96 (with #13872 and #13870 and #13865)

Here is a DC list(first 20 DCs) :

Metric;BlockKey;Path;LineStart;LineEnd;LineCount;Token;Violation
DC;1;onert-micro/onert-micro/include/pal/common/PALL2Pool2DCommon.h;34;62;29;265;Y
DC;1;onert-micro/onert-micro/include/pal/common/PALMaxPool2DCommon.h;32;60;29;265;Y
DC;2;onert-micro/onert-micro/include/pal/mcu/PALAveragePool2D.h;30;56;27;246;Y
DC;2;onert-micro/onert-micro/include/pal/mcu/PALMaxPool2D.h;30;56;27;246;Y
DC;3;onert-micro/onert-micro/include/pal/common/PALAveragePool2DCommon.h;33;58;26;224;Y
DC;3;onert-micro/onert-micro/include/pal/common/PALL2Pool2DCommon.h;34;59;26;224;Y
DC;3;onert-micro/onert-micro/include/pal/common/PALMaxPool2DCommon.h;32;57;26;224;Y
DC;4;onert-micro/onert-micro/src/train/kernels/Conv1D.cpp;69;114;46;208;Y
DC;4;onert-micro/onert-micro/src/train/kernels/FullyConnected.cpp;70;115;46;208;Y
DC;5;onert-micro/onert-micro/src/core/train/OMCheckpointLoader.cpp;139;170;32;197;Y
DC;5;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;182;216;35;197;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/Equal.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/Greater.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/GreaterEqual.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/Less.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/LessEqual.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/NotEqual.cpp;37;68;32;180;Y
DC;7;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;192;224;33;178;Y
DC;7;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;273;306;34;178;Y
DC;8;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;93;122;30;177;Y
DC;8;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;189;222;34;177;Y
DC;9;onert-micro/onert-micro/include/pal/common/PALAveragePool2DCommon.h;44;62;19;175;Y
DC;9;onert-micro/onert-micro/include/pal/mcu/PALAveragePool2D.h;47;65;19;175;Y
DC;10;onert-micro/onert-micro/src/execute/kernels/ReshapeCommon.cpp;37;67;31;173;Y
DC;10;onert-micro/onert-micro/src/train/kernels/Reshape.cpp;49;79;31;173;Y
DC;11;onert-micro/onert-micro/src/import/kernels/Conv2D.cpp;44;70;27;173;Y
DC;11;onert-micro/onert-micro/src/import/kernels/FullyConnected.cpp;45;71;27;173;Y
DC;12;onert-micro/onert-micro/src/import/kernels/Maximum.cpp;34;63;30;173;Y
DC;12;onert-micro/onert-micro/src/import/kernels/Minimum.cpp;34;63;30;173;Y
DC;13;onert-micro/onert-micro/include/pal/common/PALL2Pool2DCommon.h;43;61;19;172;Y
DC;13;onert-micro/onert-micro/include/pal/common/PALMaxPool2DCommon.h;41;59;19;172;Y
DC;13;onert-micro/onert-micro/include/pal/common/PALMaxPool2DInputGrad.h;42;60;19;172;Y
DC;14;onert-micro/onert-micro/src/train/train_optimizers/Adam.cpp;274;328;55;172;Y
DC;14;onert-micro/onert-micro/src/train/train_optimizers/SGD.cpp;99;147;49;172;Y
DC;15;onert-micro/onert-micro/src/execute/kernels/Dequantize.cpp;36;71;36;171;Y
DC;15;onert-micro/onert-micro/src/execute/kernels/Quantize.cpp;37;72;36;171;Y
DC;16;onert-micro/onert-micro/src/import/helpers/OMPoolingCommon.cpp;31;59;29;171;Y
DC;16;onert-micro/onert-micro/src/import/kernels/Softmax.cpp;36;64;29;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/Equal.cpp;35;64;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/Greater.cpp;34;63;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/GreaterEqual.cpp;35;64;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/Less.cpp;34;63;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/LessEqual.cpp;34;63;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/NotEqual.cpp;35;64;30;171;Y
DC;18;onert-micro/onert-micro/src/import/helpers/OMFloorCommon.cpp;32;57;26;169;Y
DC;18;onert-micro/onert-micro/src/import/kernels/Maximum.cpp;34;60;27;169;Y
DC;18;onert-micro/onert-micro/src/import/kernels/Minimum.cpp;34;60;27;169;Y
DC;19;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;94;122;29;167;Y
DC;19;onert-micro/onert-micro/src/core/train/OMCheckpointSaver.cpp;273;304;32;167;Y
DC;20;onert-micro/onert-micro/src/execute/kernels/Dequantize.cpp;36;69;34;164;Y
DC;20;onert-micro/onert-micro/src/execute/kernels/MathCommon.cpp;34;67;34;164;Y
DC;20;onert-micro/onert-micro/src/execute/kernels/Quantize.cpp;37;70;34;164;Y

@chunseoklee
Copy link
Contributor Author

#13924 for DC;20;onert-micro/onert-micro/src/execute/kernels/Dequantize.cpp;36;69;34;164;Y and DC;20;onert-micro/onert-micro/src/execute/kernels/Quantize.cpp;37;70;34;164;Y

#13923 for

DC;17;onert-micro/onert-micro/src/import/kernels/Equal.cpp;35;64;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/Greater.cpp;34;63;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/GreaterEqual.cpp;35;64;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/Less.cpp;34;63;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/LessEqual.cpp;34;63;30;171;Y
DC;17;onert-micro/onert-micro/src/import/kernels/NotEqual.cpp;35;64;30;171;Y

@chunseoklee
Copy link
Contributor Author

#13928 for

DC;6;onert-micro/onert-micro/src/execute/kernels/Equal.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/Greater.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/GreaterEqual.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/Less.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/LessEqual.cpp;37;68;32;180;Y
DC;6;onert-micro/onert-micro/src/execute/kernels/NotEqual.cpp;37;68;32;180;Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant